FileManager - Give better response if a download of more than one file is requested

[taniwallach]

If I select multiple files and click Download in the FileManager, the displayed page looks unusual (layout messed up) and the warnings are not particularly helpful. Giving a nicer error message and a regularly formatted page would be nice.

WeBWorK Warnings
WeBWorK has encountered warnings while processing your request. If this occured when viewing a problem, it was likely caused by an error or ambiguity in that problem. Otherwise, it may indicate a problem with the WeBWorK system itself. If you are a student, report these warnings to your professor to have them corrected. If you are a professor, please consult the warning output below for more information.

Warning messages
Use of uninitialized value $pwd in string eq at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 246.
Use of uninitialized value $pwd in string eq at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 246.
Use of uninitialized value $dir in substitution (s///) at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 1032.
Use of uninitialized value $dir in split at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 1033.
Use of uninitialized value $root in concatenation (.) or string at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 1052.
Use of uninitialized value $pwd in concatenation (.) or string at /opt/webwork/webwork2/lib/WeBWorK/ContentGenerator/Instructor/FileManager.pm line 1052.
Request information
Time	Thu Sep 26 13:15:35 2019
Method	POST
URI	/webwork2/spring17mth164/instructor/file_manager/

followed by

You can only download one file at a time.

[mgage]

These are only "undefined" warning messages (the last message is the real one). It's probably safe to use the construction $foobar//''; to uniformly make sure that every value is defined.

[drgrice1]

It seems that it would be nice to update this to create a zip file (or tar ball) and offer that for download in the event that multiple files are selected. Of course that takes some work to implement.

In any case the warnings and the garbled result should be fixed for now!

[dpvc]

The problem turns out to be due to incorrectly localizing the $action variable in the getFile() method. The action passed to getFile() is not from the UI, and so doesn't need to be localized. The change to a capitalized $action when the action passed to it is always lower-case caused the test for whether the action is a download action to fail, and the Refresh() method was being called incorrectly.

I've submitted a PR to fix the issue.

Whether it should make an archive of the files is a question for another time. (There is a "Make Archive" button that could be used to do that, and then download that, though it is a multi-step process.)

[mgage]

Thanks Davide. I’ve merged the PR. I agree that method to collect and compress an archive and download to the desktop in one step would be a good addition (and mirrors the automatic upload and unpack feature). I also agree it is for another time. In addition I would like the ability to handle files of type .zip, .tar.gz and .tgz either automatically or by setting a configuration. One goal for the next release (or the one after?) would be to make it easy for an instructor to select a working homework set and download an archive containing the set definition file, any local pg files not in the OPL, and any auxiliary files which could then be emailed to a colleague who could upload them automatically in their course. It would make it easier to share homework and eventually complete courses. We’re converging on release 2.15. Thanks again. Take care, Mike On Sep 27, 2019, at 7:04 AM, Davide P. Cervone <notifications@github.com<mailto:notifications@github.com>> wrote: The problem turns out to be due to incorrectly localizing the $action variable in the getFile() method. The action passed to getFile() is not from the UI, and so doesn't need to be localized. The change to a capitalized $action when the action passed to it is always lower-case caused the test for whether the action is a download action to fail, and the Refresh() method was being called incorrectly. I've submitted a PR to fix the issue. Whether it should make an archive of the files is a question for another time. (There is a "Make Archive" button that could be used to do that, and then download that, though it is a multi-step process.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openwebwork_webwork2_issues_1022-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAJF27D3W2RHRWVKG5CGKSDQLXSETA5CNFSM4I242EX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7YRWXQ-23issuecomment-2D535894878&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=C6Pt5AGtImanmAdcooarL-JZO8M5dSFPfs3VweYXYkE&m=pb2_hKV5vO6-vD11Al33ph1Okk4pWPP5DKyJm29CC1A&s=76gKkORbHYJyJ5LBIYN8ipy7bNf3-zJ4dVfPxDKMTwc&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAJF27EA5VENMVO43J33QKLQLXSETANCNFSM4I242EXQ&d=DwMCaQ&c=kbmfwr1Yojg42sGEpaQh5ofMHBeTl9EI2eaqQZhHbOU&r=C6Pt5AGtImanmAdcooarL-JZO8M5dSFPfs3VweYXYkE&m=pb2_hKV5vO6-vD11Al33ph1Okk4pWPP5DKyJm29CC1A&s=GUOloirN7rzqBbSdWfNAU0Yb5NDJ9HAp2zMTezHYxCg&e=>.