Fix the problem urls in the emails sent using the "E-Mail Instructor" feedback page #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feedback page. This was introduced in pull request openwebwork#986. That pull request switched from obtaining the set and problem ids cached in the WeBWorK::ContentGenerator::Problem object to attempting to find the set and problem ids from the url parameters. The problem is that the feedback page does not have those url parameters.
Contributor
|
Thanks Glenn, that was fast. I'll review and test Monday. |
Member
|
wow, yeah - I started working on a fix without realizing you'd already put this out. This looks good, thanks for cleaning up my mess! |
drdrew42
approved these changes
Feb 1, 2021
Alex-Jordan
approved these changes
Feb 2, 2021
Contributor
Alex-Jordan
left a comment
Alex-Jordan
left a comment
There was a problem hiding this comment.
Works as advertised.
Contributor
|
I'm going to merge now. It's working on my server and @drdrew42 approves. That seems like enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in pull request #986.
That pull request switched from obtaining the set and problem ids cached
in the WeBWorK::ContentGenerator::Problem object to attempting to find
the set and problem ids from the url parameters. The problem is that
the feedback page does not have those url parameters.