-
-
Notifications
You must be signed in to change notification settings - Fork 166
Ww3 feature/reduced credit #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ry variable is stored.
* develop: Change the comments in the OPL-update file to reflect where the library variable is stored. Change .gitignore to ignore the bower_components directory Conflicts: .gitignore
…3-feature/reduced_credit Conflicts: conf/defaults.config webwork3/public/js/models/ProblemSet.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a documentation error; nothing to do with reduced scoring, but needed to be fixed.
…ed credit period.
|
I'm checking this out and have the following comments
|
and similar if dates are before other dates? |
|
Thats fine that it will change in WW2 as well, its the old name and doesn't
Yes for this
I would set the due date to be reduced_scoring_date + Geoff. On Fri, May 30, 2014 at 10:47 AM, Peter Staab notifications@github.com
|
|
I’m wondering if I should use some of the settings that I have for setting dates in this case (I have them for automatically setting dates on the calendar). For example, I have a setting for "Amount of Time (in minutes) after Due Date that Answers are Open” that I can use to set the open_date if the answer_date changes. On May 30, 2014, at 10:51 AM, Geoff Goehle notifications@github.com wrote:
|
|
If you have the variables around, then I would use them. Geoff. On Fri, 2014-05-30 at 08:04 -0700, Peter Staab wrote:
|
…s blank. Also, changed to make sure the date picker is shown.
…e is not a date error.
|
I have most of these fixed. I think the problem with the reduced credit items popping up when they shouldn't be is a problem with the conversion of perl's 0/1 to javascripts true/false and I've had a few of these lately. I'm thinking that a better way to handle all of these is to convert in perl dancer as the data is sent to the client via JSON. There's a way to do this somewhat easily. I don't want to put that in this Pull request though. |
…credit * ww3-feature/true-false-issue: (23 commits) Added new boolean widgets to Problem Sets Manager. Converted perl-style 0-1 boolean to false-true. Update localOverrides.conf.dist Fix bug when tagging problems using tagging menus which can accidentally remove lines from the pg file. Update Utils.pm Update Utils.pm Update Utils.pm Changed the navigation bar to make it clearer how to select other view in the course manager. Fix bug when clicking to hide problems in LB1: some were hiding too many problems and others led to infinite loops. added comments Fixed cursor position for intervals. Stop updating problem_version and set_version tables for the admin course. Modify check_modules.pl file Collapse button is not shown when there is no site nav Added a more dynamic nav bar that can be collapsed or opened. Starts collapsed on phones but can be opened. Small tweak to make formatting on editor page look nicer Tracked down some more things that printed passwords Made it so that webowrk is more careful with plain text passwords. Fixed shibboleth target URL to go to the course selected on login. Added the ability for mathview to work with essay answers. ... Conflicts: webwork3/public/js/apps/CourseManager/main-views/ProblemSetDetailView.js webwork3/public/js/apps/CourseManager/main-views/ProblemSetsManager.js webwork3/views/main/problem_set_details.tt
|
Yes, all of her homework sets dissapeared. The visible flag was set to 0. She says she didn't change them and I am inclined to believe her. |
|
Did they disappear everywhere? In ww2 and ww3? In all views? Can you check the DB to see if they are still there and just not being shown? |
|
I'm still getting weird behavior. I checked out this branch, restarted apache, did a hard reload and opened up a set in WeBWorK3 and WeBWorK2
On a different set I try to change the dates and nothing happens, no red or green messages. |
|
Are all of these in the Problem Set Detail view? I'm not seeing this at all. Very strange. This sounds like you have some old code, but you said you have a fresh branch. I have seen one thing about the difference between ww3 and ww2. If I make some changes in the Problem Set ww3 and then go to ww2 to see if the changes have been made, then refresh the page. It seems like if it was made from a POST (probably by saving one of the values), then the current data in the ww2 pages is sent, resetting the values. This may be one thing that makes them appear out of sync. |
|
I've tried this on a third virtual machine server that I created from scratch.
I'm also noticing a lot of messages in the message pane about saving changes to dates I never messed with. I've attached some screenshots: The repeated "true to false" messages are when I'm trying to change visibility from "no" to "yes" and it keeps changing back to "no". Update:
|
|
I'll try a clean install later today, but on my development machine, I'm still not seeing this. I think you're getting a lot of messages and this autoswitching of the visible property because Backbone is trying to sync with the server and what is being returned from the server is not the same as what is sent. I was seeing a lot of messages and there were 2 PUTs sent to the server for a single change on the client side. If you view the "network" tab in your browser, how many times it is sending a PUT. I just made a small change and am now getting: if I change the visibility and if I change the due date, then I get one other one: The line "HW1" is the put command. Also, now the All Messages shows: which is what I expect. I just pushed the small change. If you don't see anything different, can you show me the output from the network of the javascript console and if possible, send the JSON of the object sent and received? |
|
I'm still getting that behavior. Each time I change visibility or reduced scoring enabled I see to puts to Notice Notice |
|
I think these are the headers (what is sent from the client to the server). Do you have the response from the server as well of these as well? If so I could tell if the client or the server is switching the value. Either way, I’m not sure what yours differs from mine. How many messages are you getting in the Messages side pane? On Jun 9, 2014, at 1:58 PM, Geoff Goehle notifications@github.com wrote:
|
|
Just one message. I dont see responses other than the 200 OK status listed next to each PUT. I turned on "core" level logging and have this. Edit: As far as I can tell the Dancer side of things is fine. It kind of looks like the JS is making two requests, one right after another. |
|
It looks like and response number 2 is |
|
I see what's going on, but am not sure why we have different results Dancer is supposed to convert true/false to 1/0 (See https://metacpan.org/pod/release/YANICK/Dancer-1.3124/lib/Dancer.pm#false ) whereas mine converts the true to 1 and I see: It doesn't appear this is getting converted, as the documentation says. Probably it's trying to save "true" to the database which doesn't make any sense, so that doesn't change and returns as 0 (converting to false). I'm also guessing that you're running the latest perl dancer (I'm on 1.3119). I wonder if there's some difference between these. I can find release notes for Dancer to see what has changed since then. (I've had some trouble updating my development machine to 1.3124). I'll try to take a look at a fresh install running 1.3124 later this evening or tomorrow morning to see if I can reproduce your results. |
|
I am running dancer version 1.3124 as reported by cpan. |
|
I had a virtual machine with dancer 1.3124 and perl 5.18 and reproduced your errors. I have just pushed a fix that works on that and my development machine (dancer 1.3119 and perl 5.12). There must have been some incompatibility between either dancer or perl versions. |
P.S. I would like to get this merged quickly since the true/false thing was introduced in the true-false branch merge and people at WCU can't use WW3 until it is fixed. |
|
This is frustrating. I'm again not these errors. When you switch the enable reduced scoring in ww3, check if the course settings in [template]/simple.conf is registering correctly. This is how the handoff between ww3 and ww2 works in terms of the course settings. I'll check my virtual machine again to see if it's another capatability issue. |
|
I'm seeing that now on my virtual machine. I should be able to fix this soon. |
|
The value gets changed to 'false' and not 0. |
|
Fixed these errors and tested them on my version running perl 5.18. I think eventually this change in true/false values will pay off, but I have to say "arrggg" right now. |
|
Its been a process... The settings seem to work now. I'm still seeing Reduced Scoring Date fields in Problem Set Details (the Properties and the Customize tab (if reduced scoring is set to enabled)) when the feature is turned off. |
… the reduced scoring field when appropriate.
|
It looks like this last one wasn't a bug, I just never got around to doing it. Just pushed more changes. It's ready to be tested again. |
Ww3 feature/reduced credit OK. It seems like things work and I need the true false stuff asap so I'm going to merge this.









Added reduced scoring to WW3. This includes: