New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild web client / front-end in React.js #109

Open
adrienjoly opened this Issue Nov 2, 2017 · 14 comments

Comments

@adrienjoly
Member

adrienjoly commented Nov 2, 2017

EDIT:

Happening in https://github.com/SkinyMonkey/sound-nuggets/issues (more info: #109 (comment))

Let @SkinyMonkey know if you need info/help about it!


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@adrienjoly adrienjoly created this issue from a note in Openwhyd's Roadmap (🎈 ToDo / up next) Nov 2, 2017

@adrienjoly adrienjoly added this to the v2.0 milestone Nov 2, 2017

@mauricesvay

This comment has been minimized.

Show comment
Hide comment
@mauricesvay

mauricesvay Nov 5, 2017

Contributor

Is there a description of what the react frontend should be?
Is it supposed to replace the current openwhyd.org? Or is it a redesigned version?

Contributor

mauricesvay commented Nov 5, 2017

Is there a description of what the react frontend should be?
Is it supposed to replace the current openwhyd.org? Or is it a redesigned version?

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 5, 2017

Contributor

Hi!

So, i just had a call with Adrien.
I worked on a clone of openwhyd for a while now.
It is pretty complete although the design is not great.

The backend code is in meteor so we would not keep it for now as we want to have a transition between openwhyd and openwhyd 2.0.

But most of the code is done with React.

Here is a screenshot:

screen shot 2017-11-05 at 12 06 24 pm

I'll post the react repo later today :)

Would you be interested in helping me make it compatible with the current openwhyd API?

Contributor

SkinyMonkey commented Nov 5, 2017

Hi!

So, i just had a call with Adrien.
I worked on a clone of openwhyd for a while now.
It is pretty complete although the design is not great.

The backend code is in meteor so we would not keep it for now as we want to have a transition between openwhyd and openwhyd 2.0.

But most of the code is done with React.

Here is a screenshot:

screen shot 2017-11-05 at 12 06 24 pm

I'll post the react repo later today :)

Would you be interested in helping me make it compatible with the current openwhyd API?

@mauricesvay

This comment has been minimized.

Show comment
Hide comment
@mauricesvay

mauricesvay Nov 5, 2017

Contributor

Wow, looks pretty complete already. I'd be happy to contribute.

Contributor

mauricesvay commented Nov 5, 2017

Wow, looks pretty complete already. I'd be happy to contribute.

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 5, 2017

Contributor

https://github.com/SkinyMonkey/sound-nuggets/tree/develop

Let me know if you need info/help about it!

Contributor

SkinyMonkey commented Nov 5, 2017

https://github.com/SkinyMonkey/sound-nuggets/tree/develop

Let me know if you need info/help about it!

@adrienjoly

This comment has been minimized.

Show comment
Hide comment
@adrienjoly

adrienjoly Nov 5, 2017

Member

Thank you for sharing your codebase with us, @SkinyMonkey! 🙌

As I told you during our call, I'm very impressed by the number of features and improvements you've developed on Diggaz, the quality of your code, and I'd love to find a way to plug your React front-end onto Openwhyd's back-end! I also think that your work may motivate many developers to join/continue your efforts in making a modern Openwhyd web app.

I'm taking that opportunity to clarify the reasons why I'd like to encourage the development of new front-end/clients rather than new back-ends (or integrated stacks like Meteor):

  • As the Whyd company gave me all Whyd/Openwhyd user data, I'm doing my best to prevent any data leak, especially confidential user data (e.g. email adresses and password hashes) => I cannot easily give access to Openwhyd's data and/or infrastructure holding our database, and therefore, I would like to use our current API as a gatekeeper.
  • If we were to plug new back-ends onto our database, I would have to review every code changes to ensure the confidentiality of user data. This may take time I may not be willing to invest at this time. I'd rather spend my time making sure that Openwhyd keeps working for our users, and motivate volunteers to work on new front-ends.
  • Another thing that I want to prevent is to break backward compatibility. Openwhyd is a platform, meaning that our front-end is just one way to use it. It's also an API that may be used by some of our music lovers. And it's also been providing a embeddable player for 3rd-party websites (a.k.a. partners). As long as I'm not sure that alternative versions of Openwhyd are backward compatible (or that users of the platform are ok to break it), I'll do my best to stick to Openwhyd's current back-end.

For all these reasons, I think that adding a standard authentication layer (like OAuth, or other, as discussed there) to Openwhyd's back-end is a good compromise. It allows developers to propose alternative front-ends/clients while keeping our platform, its features and its API endpoints fully functional. I'm happy to discuss alternative solutions, as long as they are compatible with the constraints listed above.

All that being said, whenever an alternative Openwhyd client is adopted by most of our users, I'll be happy to swap our old back-end in favour to a new one.

Member

adrienjoly commented Nov 5, 2017

Thank you for sharing your codebase with us, @SkinyMonkey! 🙌

As I told you during our call, I'm very impressed by the number of features and improvements you've developed on Diggaz, the quality of your code, and I'd love to find a way to plug your React front-end onto Openwhyd's back-end! I also think that your work may motivate many developers to join/continue your efforts in making a modern Openwhyd web app.

I'm taking that opportunity to clarify the reasons why I'd like to encourage the development of new front-end/clients rather than new back-ends (or integrated stacks like Meteor):

  • As the Whyd company gave me all Whyd/Openwhyd user data, I'm doing my best to prevent any data leak, especially confidential user data (e.g. email adresses and password hashes) => I cannot easily give access to Openwhyd's data and/or infrastructure holding our database, and therefore, I would like to use our current API as a gatekeeper.
  • If we were to plug new back-ends onto our database, I would have to review every code changes to ensure the confidentiality of user data. This may take time I may not be willing to invest at this time. I'd rather spend my time making sure that Openwhyd keeps working for our users, and motivate volunteers to work on new front-ends.
  • Another thing that I want to prevent is to break backward compatibility. Openwhyd is a platform, meaning that our front-end is just one way to use it. It's also an API that may be used by some of our music lovers. And it's also been providing a embeddable player for 3rd-party websites (a.k.a. partners). As long as I'm not sure that alternative versions of Openwhyd are backward compatible (or that users of the platform are ok to break it), I'll do my best to stick to Openwhyd's current back-end.

For all these reasons, I think that adding a standard authentication layer (like OAuth, or other, as discussed there) to Openwhyd's back-end is a good compromise. It allows developers to propose alternative front-ends/clients while keeping our platform, its features and its API endpoints fully functional. I'm happy to discuss alternative solutions, as long as they are compatible with the constraints listed above.

All that being said, whenever an alternative Openwhyd client is adopted by most of our users, I'll be happy to swap our old back-end in favour to a new one.

@adrienjoly adrienjoly changed the title from Rebuild web client in React.js --> https://github.com/openwhyd/openwhyd-react to Rebuild web client / front-end in React.js Nov 12, 2017

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 12, 2017

Contributor

Hi there! A little bump/update:

https://github.com/SkinyMonkey/sound-nuggets

I create a new separated repo, the changes to the code were such on the branch, as I removed all the backend part that I thought it would be better.
I added directions about contribution and some issues if you want to help!

This version si connected to the current openwhyd backend and most public features works!

Big plus : it solves the background playing problem we have right now!

I hope it will motivate some of you to help me ;)

https://github.com/SkinyMonkey/sound-nuggets/issues

Contributor

SkinyMonkey commented Nov 12, 2017

Hi there! A little bump/update:

https://github.com/SkinyMonkey/sound-nuggets

I create a new separated repo, the changes to the code were such on the branch, as I removed all the backend part that I thought it would be better.
I added directions about contribution and some issues if you want to help!

This version si connected to the current openwhyd backend and most public features works!

Big plus : it solves the background playing problem we have right now!

I hope it will motivate some of you to help me ;)

https://github.com/SkinyMonkey/sound-nuggets/issues

@adrienjoly

This comment has been minimized.

Show comment
Hide comment
@adrienjoly

adrienjoly Nov 12, 2017

Member

Very cool, @SkinyMonkey !

A few suggestions that may motivate volunteers / contributors to help:

  1. make sure that there's recent code in your master branch (as it's the one that people see when they visit your repo)
  2. host a functional version of your project somewhere, so that people can play with it without having to clone etc...

PS: Let me know if there's anything I can do to help this project go forward.

Member

adrienjoly commented Nov 12, 2017

Very cool, @SkinyMonkey !

A few suggestions that may motivate volunteers / contributors to help:

  1. make sure that there's recent code in your master branch (as it's the one that people see when they visit your repo)
  2. host a functional version of your project somewhere, so that people can play with it without having to clone etc...

PS: Let me know if there's anything I can do to help this project go forward.

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 12, 2017

Contributor

1 - ok, ill do it soon after a bit of cleaning
2 - same, i got a cheap domain for this :)

Contributor

SkinyMonkey commented Nov 12, 2017

1 - ok, ill do it soon after a bit of cleaning
2 - same, i got a cheap domain for this :)

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 12, 2017

Contributor

Here is a demo with the public openwhyd API :)

https://sound-nuggets.xyz/profile/4d94501d1f78ac091dbc9b4d/tracks

@mauricesvay Would you like to help me with the React part?

Contributor

SkinyMonkey commented Nov 12, 2017

Here is a demo with the public openwhyd API :)

https://sound-nuggets.xyz/profile/4d94501d1f78ac091dbc9b4d/tracks

@mauricesvay Would you like to help me with the React part?

@adrienjoly adrienjoly added this to ⚙ In progress in Development Nov 16, 2017

@adrienjoly adrienjoly moved this from 🎈 ToDo / up next to 🏃 In progress... in Openwhyd's Roadmap Nov 19, 2017

@mauricesvay

This comment has been minimized.

Show comment
Hide comment
@mauricesvay

mauricesvay Nov 24, 2017

Contributor

I can help, how can I contribute?

Contributor

mauricesvay commented Nov 24, 2017

I can help, how can I contribute?

@adrienjoly

This comment has been minimized.

Show comment
Hide comment
@adrienjoly

adrienjoly Nov 25, 2017

Member

Thank you for offering your help, @mauricesvay!

Maybe you should mention SkinyMonkey, to make sure that he sees your message.

Member

adrienjoly commented Nov 25, 2017

Thank you for offering your help, @mauricesvay!

Maybe you should mention SkinyMonkey, to make sure that he sees your message.

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Nov 25, 2017

Contributor

@mauricesvay check the code and the issues here : https://github.com/SkinyMonkey/sound-nuggets/issues

The priority is to finish a first version, using a proxy to communicate with openwhyd.org.
Right now I don't have anything precise in mind but some code review would be welcome for example :)

Contributor

SkinyMonkey commented Nov 25, 2017

@mauricesvay check the code and the issues here : https://github.com/SkinyMonkey/sound-nuggets/issues

The priority is to finish a first version, using a proxy to communicate with openwhyd.org.
Right now I don't have anything precise in mind but some code review would be welcome for example :)

@rodrigofepy

This comment has been minimized.

Show comment
Hide comment
@rodrigofepy

rodrigofepy Dec 18, 2017

@SkinyMonkey I'd be happy to contribute too.

rodrigofepy commented Dec 18, 2017

@SkinyMonkey I'd be happy to contribute too.

@SkinyMonkey

This comment has been minimized.

Show comment
Hide comment
@SkinyMonkey

SkinyMonkey Dec 18, 2017

Contributor

Hi @rodrigofepy, @mauricesvay !

Thank you for your interest in the project :)

The 'follow' button is a crucial feature that is missing, if you want to check the code and try to add it?
Ask me in the project's issue if you have questions about the code so it stays online for people to read :)

Also I just added somes issues that should not be hard to solve if you want to try :
SkinyMonkey/sound-nuggets#18
SkinyMonkey/sound-nuggets#19
SkinyMonkey/sound-nuggets#21
SkinyMonkey/sound-nuggets#22
(The last one is a feature)

Finally some css could be done/improved, i'm not a great designer :/

Thank you so much for your help!

Contributor

SkinyMonkey commented Dec 18, 2017

Hi @rodrigofepy, @mauricesvay !

Thank you for your interest in the project :)

The 'follow' button is a crucial feature that is missing, if you want to check the code and try to add it?
Ask me in the project's issue if you have questions about the code so it stays online for people to read :)

Also I just added somes issues that should not be hard to solve if you want to try :
SkinyMonkey/sound-nuggets#18
SkinyMonkey/sound-nuggets#19
SkinyMonkey/sound-nuggets#21
SkinyMonkey/sound-nuggets#22
(The last one is a feature)

Finally some css could be done/improved, i'm not a great designer :/

Thank you so much for your help!

@adrienjoly adrienjoly moved this from ⚙ In progress to ✔️ Done / pending QA in Development Aug 26, 2018

@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 📥 Inbox / ideas in Development Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment