New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved models to standard freeradius schema #7

Merged
merged 3 commits into from Jun 5, 2017

Conversation

Projects
None yet
4 participants
@lillopaco
Member

lillopaco commented Jun 3, 2017

We decided to focus on standard freeradius schema for now, to have quickly a working environment to test and iterate.
Covers the following points of of #1:

  • ensure database structure works with freeradius
  • add radius related models
  • add admin interface to manipulate database objects

@lillopaco lillopaco requested review from yakky and nemesisdesign Jun 3, 2017

@coveralls

This comment has been minimized.

coveralls commented Jun 3, 2017

Coverage Status

Coverage decreased (-0.5%) to 94.35% when pulling 150f408 on freeradius_models into eadf8c2 on master.

@yakky

yakky approved these changes Jun 3, 2017 edited

Overall great job!
Congrats for your first GSOC pull request
Coverage lowering is expected: we have no test at this stage, and it's not needed for this PR

@nemesisdesign

good job @lillopaco 👍

@nemesisdesign nemesisdesign merged commit e58d638 into master Jun 5, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.5%) to 94.35%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lillopaco lillopaco deleted the freeradius_models branch Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment