Skip to content

Commit dde3c9b

Browse files
committed
[openvpn] Added explicit list_identifiers attribute
1 parent 5ddc201 commit dde3c9b

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

netjsonconfig/backends/openvpn/openvpn.py

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ class OpenVpn(BaseBackend):
1414
schema = schema
1515
converters = [converters.OpenVpn]
1616
renderer = OpenVpnRenderer
17+
list_identifiers = ['name']
1718
VPN_REGEXP = re.compile('# openvpn config: ')
1819

1920
def _generate_contents(self, tar):

tests/openvpn/test_backend.py

+17-1
Original file line numberDiff line numberDiff line change
@@ -200,14 +200,14 @@ def test_client_mode(self):
200200

201201
_simple_conf = {
202202
"openvpn": [{
203+
"name": "test",
203204
"ca": "ca.pem",
204205
"cert": "cert.pem",
205206
"dev": "tap0",
206207
"dev_type": "tap",
207208
"dh": "dh.pem",
208209
"key": "key.pem",
209210
"mode": "server",
210-
"name": "test",
211211
"proto": "udp",
212212
"status": "",
213213
"status_version": 1,
@@ -683,3 +683,19 @@ def test_resolv_retry_invalid(self):
683683
def test_double_rendering(self):
684684
o = OpenVpn(self._simple_conf)
685685
self.assertEqual(o.render(), o.render())
686+
687+
def test_override(self):
688+
template = {
689+
"openvpn": [{
690+
"name": "test",
691+
"ca": "TEST",
692+
"cert": "TEST",
693+
"dev": "TEST",
694+
"dev_type": "TEST",
695+
"dh": "TEST",
696+
"key": "TEST",
697+
}]
698+
}
699+
o = OpenVpn(self._simple_conf, templates=[template])
700+
# ensure dummy values in template have been overridden
701+
self.assertDictEqual(o.config, self._simple_conf)

0 commit comments

Comments
 (0)