New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridging issues #22

Closed
nemesisdesign opened this Issue Oct 26, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@nemesisdesign
Member

nemesisdesign commented Oct 26, 2015

Trying different combinations with bridges yelds very strange (and wrong) results.

Generation of bridged interfaces must be improved.

  • the whole __find_bridges idea is quite a bad one. It would be better to remove that code altoghether and find a simpler solution.
  • bridges should be defined only in /etc/config/network.
  • in /etc/config/wireless the attached networks can be defined with a custom attribute, like networks.
  • the bridge schema should require the presence of bridge_members

@nemesisdesign nemesisdesign added the bug label Oct 26, 2015

@nemesisdesign nemesisdesign self-assigned this Oct 26, 2015

@nemesisdesign nemesisdesign added this to the 0.2 milestone Oct 26, 2015

nemesisdesign added a commit that referenced this issue Oct 27, 2015

Improved & simplified bridging #22
* removed __find_bridges crap
* added "networks" attribute in wireless interfaces
@riblo

This comment has been minimized.

Member

riblo commented Oct 28, 2015

trying to define a bridge interface without specifying "bridge_members" raises this exception:

Traceback (most recent call last):
  File "/Users/Riccardo/.virtualenvs/netjsonconfig/bin/netjsonconfig", line 10, in <module>
    execfile(__file__)
  File "/Users/Riccardo/Work/netjsonconfig/bin/netjsonconfig", line 93, in <module>
    output = getattr(instance, args.method)()
  File "/Users/Riccardo/Work/netjsonconfig/netjsonconfig/backends/openwrt/openwrt.py", line 75, in render
    additional_output = renderer.render()
  File "/Users/Riccardo/Work/netjsonconfig/netjsonconfig/backends/base.py", line 43, in render
    context = self.get_context()
  File "/Users/Riccardo/Work/netjsonconfig/netjsonconfig/backends/base.py", line 57, in get_context
    context[key] = getattr(self, method)()
  File "/Users/Riccardo/Work/netjsonconfig/netjsonconfig/backends/openwrt/renderers.py", line 34, in _get_interfaces
    bridge_members = ' '.join(interface['bridge_members'])
KeyError: 'bridge_members'

nemesisdesign added a commit that referenced this issue Nov 2, 2015

[schema] Improved definition of interfaces
This improvement was required to close the last point of issue #22:
"the bridge schema should require the presence of bridge_members"

nemesisdesign added a commit that referenced this issue Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment