New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwrt] Drop "enabled" logic in OpenVpnRenderer in 0.6.0 #58

Closed
nemesisdesign opened this Issue Jan 17, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@nemesisdesign
Member

nemesisdesign commented Jan 17, 2017

Solve the issues explained by the comments marked as TODO in 7a152a3.

@jack17529

This comment has been minimized.

jack17529 commented Mar 21, 2017

@nemesisdesign ok sir I will solve them.

@nemesisdesign

This comment has been minimized.

Member

nemesisdesign commented Mar 21, 2017

@jack17529 I did not specify that this must be done in the 0.6.0 release, not now. It's a reminder for a minor cleanup. Thanks anyway.

@nemesisdesign nemesisdesign changed the title from [openwrt] Drop "enabled" logic in OpenVpnRenderer to [openwrt] Drop "enabled" logic in OpenVpnRenderer in 0.6.0 Mar 21, 2017

@jack17529

This comment has been minimized.

jack17529 commented Mar 22, 2017

@nemesisdesign so should I not touch the code?

@nemesisdesign

This comment has been minimized.

Member

nemesisdesign commented Mar 22, 2017

@jack17529 no it's not needed. I'll take care of it. I suggest you to find ways to contribute that are more useful to us. Stuff I don't have time to do, finding new bugs. Triaging tickets. Whatever you can do to help out.

@jack17529

This comment has been minimized.

jack17529 commented Mar 22, 2017

@nemesisdesign roger that .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment