Skip to content

/ netjsonconfig

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failing for python2 #97

Closed
nemesisdesign opened this issue Aug 29, 2017 · 0 comments
Closed

Build failing for python2 #97

nemesisdesign opened this issue Aug 29, 2017 · 0 comments
Labels
bug

Comments

@nemesisdesign
Copy link
Member

@nemesisdesign nemesisdesign commented Aug 29, 2017 •
edited

@ritwickdsouza @edoput, I found out how to reproduce the issue:

pip uninstall py2-ipaddress -y
pip install https://github.com/phihag/ipaddress/tarball/master

Run the tests with that version of the library and tests will fail on python2.

Currently looking for a fix, this bug is causing problems downstream.
@nemesisdesign nemesisdesign added the bug label Aug 29, 2017
nemesisdesign added a commit that referenced this issue Aug 29, 2017
@nemesisdesign
[python2] Fixed py2-ipaddress related unicode bug #97
Loading status checks…
61801a1 
For some strange reason this bug popped out of the blue.
Apparently arguments passed to the ipaddress library
must be unicode strings.

No idea why this didn't come up earlier.

Closes #97
@nemesisdesign nemesisdesign mentioned this issue Aug 29, 2017
Merged
@nemesisdesign nemesisdesign mentioned this issue Aug 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@nemesisdesign