Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add further options to the OpenVPN backend #108

Merged
merged 2 commits into from Jul 9, 2018

Conversation

okraits
Copy link
Member

@okraits okraits commented Jun 25, 2018

This PR extends the OpenVPN backend with a couple of additional options.

It's not completely done yet - I have to adapt the auto_client classmethod in openvpn.py and add tests for the new options.

@coveralls
Copy link

coveralls commented Jun 25, 2018

Coverage Status

Coverage remained the same at 99.931% when pulling 405f884 on TDT-AG:tdt-extend-openvpn into 36f9f34 on openwisp:master.

@edoput edoput changed the title Add further options to the OpenVPN backend WIP: Add further options to the OpenVPN backend Jun 25, 2018
@nemesifier
Copy link
Member

@okraits can you fix the breaking build?

@okraits
Copy link
Member Author

okraits commented Jul 6, 2018

@nemesisdesign Fixed :-)

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @okraits, thank you!

@nemesifier nemesifier merged commit 405f884 into openwisp:master Jul 9, 2018
nemesifier added a commit that referenced this pull request Jul 9, 2018
- avoid duplication of description
- use `reneg-sec` instead of `reneg_sec` in label
@okraits okraits deleted the tdt-extend-openvpn branch July 25, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants