New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add further options to the OpenVPN backend #108

Merged
merged 2 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@okraits
Member

okraits commented Jun 25, 2018

This PR extends the OpenVPN backend with a couple of additional options.

It's not completely done yet - I have to adapt the auto_client classmethod in openvpn.py and add tests for the new options.

@coveralls

This comment has been minimized.

coveralls commented Jun 25, 2018

Coverage Status

Coverage remained the same at 99.931% when pulling 405f884 on TDT-AG:tdt-extend-openvpn into 36f9f34 on openwisp:master.

@edoput edoput changed the title from Add further options to the OpenVPN backend to WIP: Add further options to the OpenVPN backend Jun 25, 2018

@okraits okraits force-pushed the TDT-AG:tdt-extend-openvpn branch from a3c65b8 to c5a5623 Jun 26, 2018

@nemesisdesign

This comment has been minimized.

Member

nemesisdesign commented Jul 4, 2018

@okraits can you fix the breaking build?

@okraits okraits force-pushed the TDT-AG:tdt-extend-openvpn branch from c5a5623 to 4a85ef0 Jul 6, 2018

@okraits okraits force-pushed the TDT-AG:tdt-extend-openvpn branch from 4a85ef0 to 3fba322 Jul 6, 2018

@okraits

This comment has been minimized.

Member

okraits commented Jul 6, 2018

@nemesisdesign Fixed :-)

@nemesisdesign

Great work @okraits, thank you!

@nemesisdesign nemesisdesign merged commit 405f884 into openwisp:master Jul 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.931%
Details

nemesisdesign added a commit that referenced this pull request Jul 9, 2018

[openvpn] Improved patch #108
- avoid duplication of description
- use `reneg-sec` instead of `reneg_sec` in label

@okraits okraits deleted the TDT-AG:tdt-extend-openvpn branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment