New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zonename attribute #65

Merged
merged 3 commits into from Mar 10, 2017

Conversation

Projects
None yet
3 participants
@ritwickdsouza
Member

ritwickdsouza commented Mar 10, 2017

Solves #61. Please review.

@coveralls

This comment has been minimized.

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a569f8f on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@nemesisdesign

This comment has been minimized.

Member

nemesisdesign commented Mar 10, 2017

@ritwickdsouza good!

Please update also the example in the documentation for the OpenWRT backend:

https://github.com/openwisp/netjsonconfig/blob/master/docs/source/backends/openwrt.rst#general-settings-example

The example should reflect the change you just introduced.

(the result is published at http://netjsonconfig.openwisp.org/en/latest/backends/openwrt.html#general-settings).

@coveralls

This comment has been minimized.

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c7b3d2b on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2061929 on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@nemesisdesign

This comment has been minimized.

Member

nemesisdesign commented Mar 10, 2017

Good job. Thanks.

@nemesisdesign nemesisdesign merged commit 4c1bccd into openwisp:master Mar 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@ritwickdsouza ritwickdsouza deleted the ritwickdsouza:zonename-attribute branch Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment