Skip to content

Conversation

@ritwickdsouza
Copy link
Contributor

@ritwickdsouza ritwickdsouza commented Mar 10, 2017

Solves #61. Please review.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a569f8f on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@nemesifier
Copy link
Member

@ritwickdsouza good!

Please update also the example in the documentation for the OpenWRT backend:

https://github.com/openwisp/netjsonconfig/blob/master/docs/source/backends/openwrt.rst#general-settings-example

The example should reflect the change you just introduced.

(the result is published at http://netjsonconfig.openwisp.org/en/latest/backends/openwrt.html#general-settings).

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling c7b3d2b on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@coveralls
Copy link

coveralls commented Mar 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2061929 on ritwickdsouza:zonename-attribute into 3112afe on openwisp:master.

@nemesifier
Copy link
Member

Good job. Thanks.

@nemesifier nemesifier merged commit 4c1bccd into openwisp:master Mar 10, 2017
@ritwickdsouza ritwickdsouza deleted the zonename-attribute branch March 10, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants