Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Changed toast for login error when connection refused #245

Merged
merged 3 commits into from May 31, 2021

Conversation

codesankalp
Copy link
Member

@codesankalp codesankalp commented May 25, 2021

Closes #241

@codesankalp codesankalp added this to Review in progress in [GSoC 2021] wifi-login-pages May 25, 2021
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a failing test for this?

@codesankalp
Copy link
Member Author

Can you please add a failing test for this?

yes

@codesankalp
Copy link
Member Author

codesankalp commented May 26, 2021

Now after adding the commit in #244 the toast content is now internal server error when the radius server is stopped
but when we stop express server it gives login error occured

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, please see comments below.

client/components/login/login.test.js Outdated Show resolved Hide resolved
client/components/login/login.test.js Outdated Show resolved Hide resolved
client/components/login/login.test.js Show resolved Hide resolved
@codesankalp codesankalp force-pushed the issue-241-account-deactivated-toast branch from ad1f25c to 24745e6 Compare May 29, 2021 05:37
@codesankalp codesankalp force-pushed the issue-241-account-deactivated-toast branch from 24745e6 to 0749a4e Compare May 29, 2021 05:38
[GSoC 2021] wifi-login-pages automation moved this from Review in progress to Reviewer approved May 31, 2021
@nemesifier nemesifier merged commit 2caafed into master May 31, 2021
[GSoC 2021] wifi-login-pages automation moved this from Reviewer approved to Done May 31, 2021
@nemesifier nemesifier deleted the issue-241-account-deactivated-toast branch May 31, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[bug] Your account has been deactivated, but it's not true
2 participants