Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foraging Amplitude Units #206

Open
MichaelCurrie opened this issue Jun 13, 2017 · 4 comments
Open

Foraging Amplitude Units #206

MichaelCurrie opened this issue Jun 13, 2017 · 4 comments

Comments

@MichaelCurrie
Copy link

From @ver228

A quick question. I am documenting the features however I found in this document ( https://github.com/openworm/open-worm-analysis-toolbox/blob/master/documentation/database%20schema/Features%20Specifications.xlsx) that locomotion.foraging_bends.amplitude should have units of micrometers.

However, for what i understand from the code the foraging_bends.amplitude is the maxima of the nose angles within a time window (https://github.com/openworm/open-worm-analysis-toolbox/blob/master/open_worm_analysis_toolbox/features/locomotion_bends.py#L679), so it should have units of degrees.

I think the units might be wrong in the original paper. From the Supplementary Material "The foraging amplitude is defined as the largest foraging angle measured, prior to crossing 0°", and because it is an angle it clearly should have units of degrees, but then in Supplementary Table 2 the corresponding features do have units of Microns.

@MichaelCurrie
Copy link
Author

MichaelCurrie commented Jun 13, 2017

@ver228 from everything you say it certainly makes sense that it should be degrees. I wonder if we should seek clarification from @Eviatar.

@Eviatar
Copy link

Eviatar commented Jun 13, 2017

Yep, my mistake. We discovered this a few days ago. I've been working with Andre & Avelino to help move the code forward. There are a few things on the list & the goal is to take care of them just after the UCLA worm meeting this coming week.

@MichaelCurrie
Copy link
Author

MichaelCurrie commented Jun 13, 2017

OK thanks @Eviatar, see you there btw! WCON's poster session is Thursday 22 June from 21:00 to 22:30.

@Eviatar
Copy link

Eviatar commented Jun 13, 2017

Awesome, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants