New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smcroute: make build id optional #331

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
4 participants
@lynxis
Contributor

lynxis commented Dec 2, 2017

The build id contains the build timestamp by default.
Make this field optional.
Build timestamp prevents reproducible builds [0].
Thanks to the debian project for the patch.

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens lynxis@fe80.eu

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 2, 2017

Contributor

Sorry, this was too fast. It's missing a build test.

Contributor

lynxis commented Dec 2, 2017

Sorry, this was too fast. It's missing a build test.

smcroute: make build id optional
The build id contains the build timestamp by default.
Make this field optional.
Build timestamp prevents reproducible builds [0].
Thanks to the debian project for the patch.

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 2, 2017

Contributor

it builds now.
@dangowrt @mwarning

Contributor

lynxis commented Dec 2, 2017

it builds now.
@dangowrt @mwarning

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis
Contributor

lynxis commented Dec 6, 2017

@mwarning

This comment has been minimized.

Show comment
Hide comment
@mwarning

mwarning Dec 6, 2017

Member

@lynxis what's up?

Member

mwarning commented Dec 6, 2017

@lynxis what's up?

@lbschenkel

This comment has been minimized.

Show comment
Hide comment
@lbschenkel

lbschenkel Dec 6, 2017

Contributor

+1

Contributor

lbschenkel commented Dec 6, 2017

+1

1 similar comment
@mwarning

This comment has been minimized.

Show comment
Hide comment
@mwarning

mwarning Dec 6, 2017

Member

+1

Member

mwarning commented Dec 6, 2017

+1

@jow- jow- merged commit 5457ae6 into openwrt-routing:master Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment