Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header topmenu shown logged out #3653

Closed
johnnytolengo opened this issue Feb 19, 2020 · 8 comments
Closed

Header topmenu shown logged out #3653

johnnytolengo opened this issue Feb 19, 2020 · 8 comments
Labels
probably a bug issue could be a bug

Comments

@johnnytolengo
Copy link

On commit r11655-a283b1788a the topmenu "

" is shown while no user logged in.

image

Any idea how to solve this issue?
Thank you.

@feckert feckert added the probably a bug issue could be a bug label Feb 20, 2020
@jow-
Copy link
Contributor

jow- commented Feb 20, 2020

This is intentional.

@jow- jow- closed this as completed Feb 20, 2020
@castillofrancodamian
Copy link
Contributor

But it reveals device information. It should be removed or at least able to deactivate

@feckert
Copy link
Member

feckert commented Feb 26, 2020

If I use the luci-theme-material i do not see the menu if i am not logged in!

@jow-
Copy link
Contributor

jow- commented Feb 26, 2020

But it reveals device information. It should be removed or at least able to deactivate

So does a curl -v http://192.168.1.1/luci-static/resources/. With the client side implementation it is not possible to hide what is available anymore, you can simply probe the URLs.

@johnnytolengo
Copy link
Author

I think it is not good to show that sensible information, the menu reveals what kind packages you have already installed and so on.

@jow-
Copy link
Contributor

jow- commented Feb 26, 2020

Even if the menu is hidden you can still obtain that information easily, it provides zero security benefit.

@johnnytolengo
Copy link
Author

that is true, but I don't undestand what is the benefit/reason to show the menu while you are logged out.

@jow-
Copy link
Contributor

jow- commented Feb 26, 2020

See #3563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
probably a bug issue could be a bug
Projects
None yet
Development

No branches or pull requests

4 participants