Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbound: Basic LuCI to go with recent Unbound UCI enhancements #864

Merged
merged 1 commit into from Dec 5, 2016
Merged

Unbound: Basic LuCI to go with recent Unbound UCI enhancements #864

merged 1 commit into from Dec 5, 2016

Conversation

EricLuehrsen
Copy link
Contributor

Compile tested: ar71xx OpenWrt 15.05.1
Run tested: TL-WDR3600
Description: Basic LuCI to go with recent Unbound UCI enhancements
cc: @hansmi @Borromini


prt = s:taboption("service", Value, "listen_port", translate("Listening Port:"),
translate("Unbound will listen for queries on this port."))
prt.datatype = "and(uinteger,53,min(1024),max(8192))"
Copy link
Contributor

@hnyman hnyman Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prt.datatype = "and(uinteger,53,min(1024),max(8192))"

I think that you are aiming at (53 or 1024-8192) right?
Did you test this?
I have not tested this myself, but the datatype looks suspicious. Almost as if you would require it to be both 53 and at least 1024 at the same time. That might require more complex datatype (or alternatively, a validation function).

"and(port,max(8192),or(53,min(1024)))" ???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry ... tested, failed, and the page overall was ugly. I fouled up rotating and squashing commits from my test branch to this pull branch. I actually decided to just let it be "port."

@poranje
Copy link
Contributor

poranje commented Dec 4, 2016 via email

@EricLuehrsen
Copy link
Contributor Author

@poranje - Yes exactly. See README.md in packages/net/unbound.

Signed-off-by: Eric Luehrsen <ericluehrsen@hotmail.com>
@hnyman hnyman merged commit a9d74a6 into openwrt:master Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants