Skip to content
Permalink
Browse files
treewide: dts: Remove default-state=off property from all gpio LED nodes
>From the Documentation/devicetree/bindings/leds/common.txt:

- default-state : The initial state of the LED. Valid values are "on", "off",
  and "keep". If the LED is already on or off and the default-state property is
  set the to same value, then no glitch should be produced where the LED
  momentarily turns off (or on). The "keep" setting will keep the LED at
  whatever its current state is, without producing a glitch.  The default is
  off if this property is not present.

So setting the default-state of the LEDs to `off` is redundant as `off`
is default LED state anyway. We should remove it as almost every new
PR/patch submission contains this property by default which seems to be
just copy&paste from some DTS file already present in the tree.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
  • Loading branch information
ynezz authored and blogic committed Dec 17, 2018
1 parent 1e4ee63 commit 0d23fd2ab29a66f5d03187db4fac3e396b4f3b62
Showing 72 changed files with 0 additions and 233 deletions.
@@ -98,19 +98,16 @@
led0 {
label = "wb50n:blue:led0";
gpios = <&pioA 12 GPIO_ACTIVE_LOW>;
default-state = "off";
};

led1 {
label = "wb50n:green:led1";
gpios = <&pioA 24 GPIO_ACTIVE_LOW>;
default-state = "off";
};

led2 {
label = "wb50n:red:led2";
gpios = <&pioA 26 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};
};
@@ -29,32 +29,27 @@
children {
label = "wn-ag300dgr:green:children";
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
default-state = "off";
};

eco {
label = "wn-ag300dgr:green:eco";
gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
default-state = "off";
};

notification {
label = "wn-ag300dgr:amber:notification";
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
default-state = "off";
};

wlan2g {
label = "wn-ag300dgr:green:wlan2g";
gpios = <&gpio 12 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};

wlan5g {
label = "wn-ag300dgr:green:wlan5g";
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy1tpt";
};
};
@@ -33,7 +33,6 @@
diag: diag {
label = "buffalo:red:diag";
gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -44,47 +43,40 @@
band2g_a {
label = "buffalo:amber:band2g";
gpios = <&ath9k0 1 GPIO_ACTIVE_LOW>;
default-state = "off";
};

usb {
label = "buffalo:green:usb";
gpios = <&ath9k0 3 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&usb_ochi_port>, <&usb_echi_port>;
linux,default-trigger = "usbport";
};

band2g_g {
label = "buffalo:green:band2g";
gpios = <&ath9k0 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};

band5g_g {
label = "buffalo:green:band5g";
gpios = <&ath9k1 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy1tpt";
};

router {
label = "buffalo:green:router";
gpios = <&ath9k1 3 GPIO_ACTIVE_LOW>;
default-state = "off";
};

movie_engine {
label = "buffalo:blue:movie_engine";
gpios = <&ath9k1 4 GPIO_ACTIVE_LOW>;
default-state = "off";
};

band5g_a {
label = "buffalo:amber:band5g";
gpios = <&ath9k1 5 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -33,7 +33,6 @@
blue_usb {
label = "d-link:blue:usb";
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&usb_ochi_port>, <&usb_echi_port>;
linux,default-trigger = "usbport";
};
@@ -47,25 +46,21 @@
blue_power: blue_power {
label = "d-link:blue:power";
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
default-state = "off";
};

blue_wps {
label = "d-link:blue:wps";
gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
default-state = "off";
};

orange_planet {
label = "d-link:orange:planet";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
default-state = "off";
};

blue_planet {
label = "d-link:blue:planet";
gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -75,14 +70,12 @@
wlan2g {
label = "d-link:blue:wlan2g";
gpios = <&ath9k0 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};

wlan5g {
label = "d-link:blue:wlan5g";
gpios = <&ath9k1 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy1tpt";
};
};
@@ -42,13 +42,11 @@
wps {
label = "netgear:orange:wps";
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
default-state = "off";
};

power_green: power_green {
label = "netgear:green:power";
gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
default-state = "off";
};

power_orange: power_orange {
@@ -60,13 +58,11 @@
wps_green {
label = "netgear:green:wps";
gpios = <&gpio 4 GPIO_ACTIVE_LOW>;
default-state = "off";
};

wan_green {
label = "netgear:green:wan";
gpios = <&gpio 6 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -75,13 +71,11 @@
wlan2g {
label = "netgear:green:wlan2g";
gpios = <&ath9k0 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
wlan5g {
label = "netgear:blue:wlan5g";
gpios = <&ath9k1 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy1tpt";
};
};
@@ -31,7 +31,6 @@
rf: rf_green {
label = "ubnt:green:rf";
gpios = <&gpio 2 GPIO_ACTIVE_HIGH>;
default-state = "off";
};
};

@@ -103,7 +103,6 @@
wlan {
label = "whr-g301n:green:wlan";
gpios = <&ath9k 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -51,7 +51,6 @@
wlan: wlan {
label = "netgear:green:wlan";
gpios = <&ath9k 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -79,7 +79,6 @@
wlan {
label = "tp-link:green:wlan";
gpios = <&ath9k 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -13,7 +13,6 @@
wlan {
label = "tp-link:green:wlan";
gpios = <&ath9k 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -13,7 +13,6 @@
wlan {
label = "tp-link:green:wlan";
gpios = <&ath9k 0 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -19,7 +19,6 @@
led3g {
label = "tp-link:green:3g";
gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&hub_port>;
linux,default-trigger = "usbport";
};
@@ -13,7 +13,6 @@
wlan {
label = "tp-link:green:wlan";
gpios = <&ath9k 0 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -43,19 +43,16 @@

sec_vpn: sec_vpn {
gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
default-state = "off";
};

diag: diag {
label = "buffalo:red:diag";
gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
default-state = "off";
};

usb {
label = "buffalo:green:usb";
gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&hub_port>;
linux,default-trigger = "usbport";
};
@@ -70,7 +70,6 @@
diag: diag {
label = "buffalo:red:diag";
gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -80,40 +79,34 @@
usb {
label = "buffalo:blue:usb";
gpios = <&ath9k 4 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&hub_port>;
linux,default-trigger = "usbport";
};

wireless {
label = "buffalo:green:wireless";
gpios = <&ath9k 5 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};

security {
label = "buffalo:orange:security";
gpios = <&ath9k 6 GPIO_ACTIVE_LOW>;
default-state = "off";
};

router {
label = "buffalo:green:router";
gpios = <&ath9k 7 GPIO_ACTIVE_LOW>;
default-state = "off";
};

movie_engine_on {
label = "buffalo:blue:movie_engine_on";
gpios = <&ath9k 8 GPIO_ACTIVE_LOW>;
default-state = "off";
};

movie_engine_off {
label = "buffalo:blue:movie_engine_off";
gpios = <&ath9k 9 GPIO_ACTIVE_LOW>;
default-state = "off";
};
};

@@ -16,19 +16,16 @@
led_movie_engine {
label = "buffalo:blue:movie_engine";
gpios = <&ath9k 13 GPIO_ACTIVE_LOW>;
default-state = "off";
};

router {
label = "buffalo:green:router";
gpios = <&ath9k 14 GPIO_ACTIVE_LOW>;
default-state = "off";
};

wireless {
label = "buffalo:green:wireless";
gpios = <&ath9k 15 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -52,13 +52,11 @@
system: wps {
label = "tplink:green:wps";
gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
default-state = "off";
};

usb {
label = "tplink:green:usb";
gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
default-state = "off";
trigger-sources = <&hub_port>;
linux,default-trigger = "usbport";
};
@@ -70,14 +68,12 @@
wlan2g {
label = "tplink:green:wlan2g";
gpios = <&ath9k 0 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};

wlan5g {
label = "tplink:green:wlan5g";
gpios = <&ath9k 1 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};
@@ -52,13 +52,11 @@
qss {
label = "tp-link:green:qss";
gpios = <&gpio 4 GPIO_ACTIVE_HIGH>;
default-state = "off";
};

wlan {
label = "tp-link:green:wlan";
gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
default-state = "off";
linux,default-trigger = "phy0tpt";
};
};

0 comments on commit 0d23fd2

Please sign in to comment.