apk: wget download stalls on package install or the install fails with ADB integrity error

[Svaag]

Describe the bug

When trying to install packages with the tilde (~) character in name, such as commit hash stamped packages (sedutil-2022.12.27~7a0cda7f-r2.apk) the new installation code for APK does not send entire package name/url to wget as such:

23348 root      1216 S    /www/cgi-bin/cgi-exec
23349 root      1396 S    {package-manager} /bin/sh /usr/libexec/package-manager-call install sedutil
23350 root      1396 S    {package-manager} /bin/sh /usr/libexec/package-manager-call install sedutil
23352 root     12788 S    apk add sedutil
23362 root      7976 S    wget -q -T 60 https://downloads.openwrt.org/snapshots/packages/aarch64_cortex-a53/packages/sedutil-2022.1

Error is present also in manual apk add:

root@BPI-R4:~# apk add sedutil
(1/2) Installing libstdcpp6 (13.3.0-r4)
Executing libstdcpp6-13.3.0-r4.post-install
(2/2) Installing sedutil (2022.12.27~7a0cda7f-r2)
 83% ############################################################################################################################################

Wget stalled in same way:

root@BPI-R4:~# ps w | grep sed
23422 root     12788 S    apk add sedutil
23432 root      7976 S    wget -q -T 60 https://downloads.openwrt.org/snapshots/packages/aarch64_cortex-a53/packages/sedutil-2022.1

Just to confirm, manual download and apk add works:

root@BPI-R4:~# apk add --allow-untrusted sedutil-2022.12.27\~7a0cda7f-r2.apk
(1/2) Installing libstdcpp6 (13.3.0-r4)
Executing libstdcpp6-13.3.0-r4.post-install
(2/2) Installing sedutil (2022.12.27~7a0cda7f-r2)
Executing sedutil-2022.12.27~7a0cda7f-r2.post-install
OK: 121 MiB in 327 packages

OpenWrt version

r28203-f4492b6b1c

OpenWrt release

SNAPSHOT

OpenWrt target/subtarget

mediatek/filogic

Device

Bananapi BPI-R4

Image kind

Official downloaded image

Steps to reproduce

No response

Actual behaviour

No response

Expected behaviour

No response

Additional info

No response

Diffconfig

No response

Terms

• I am reporting an issue for OpenWrt, not an unsupported fork.

[Svaag]

After purging apk cache and redownloading ADB lists the install works. I realized this after getting APKE_ADB_INTEGRITY "ADB integrity error" on apk commands. Closing case and reopening if I run into this again.

[ynezz]

If you don't mind, I'll keep this open, looks valid to me. Any chance for reproducer?

[Svaag]

After finding the workaround/fix I started thinking that the tilde naming was a coincidence/red herring and the real underlying issue all along was the APKE_ADB_INTEGRITY issue that got solved by purging cached .adb files from repo.

Also noticed yesterday after fixing that sedutil package in SNAPSHOT repo is timestamped Wed Dec 11 19:28:10 2024 and my first installation attempt was sometime around then but I can't say exactly when.

Another repo thing that caught my eye just now is sha256sums has timestamp Thu Dec 12 02:39:50 2024 which is just a couple hours before I closed the issue with my workaround.

Maybe some race condition timing issue somewhere between make world on build server, repo sync, client package-list sync, and download of the actual package? First compiled .apk's turn up around Wed Dec 11 18:32:18 and if sha256sums is only generated at end of buildserver job 8 hours later Thu Dec 12 02:39:50 2024 then I could imagine a few cases where a package manager might fail due to mismatch between client & repo states.