Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#423 - Linksys WRT1900ACS USB led names are wrong #5489

Closed
openwrt-bot opened this issue Jan 22, 2017 · 11 comments
Closed

FS#423 - Linksys WRT1900ACS USB led names are wrong #5489

openwrt-bot opened this issue Jan 22, 2017 · 11 comments
Labels

Comments

@openwrt-bot
Copy link

openwrt-bot commented Jan 22, 2017

howl:

At least in WRT1900ACS but it could be in another Linksys WRT AC series the USB led names are wrong. The device has USB1 and USB2 leds, but in the default configuration USB2 and USB3 are set up.

https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/mvebu/base-files/etc/board.d/01_leds;h=d6e42ddfd590ff8e6136bffafd0c57159f1cbb98;hb=9641ceea0ce68d1c507b9d2bbe7cf8da518a2eb8

I don't know if USB2 should be USB1 and USB3 should be USB2, or only USB3 must be renamed to USB1.

Will try to make sure what of the two possible changes is the correct one and then comment it here.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 23, 2017

howl:

The renaming should be as follow:
USB2 -> USB1
USB3 -> USB2

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 24, 2017

jow-:

I think the LED names are supposed to denote USB 2.0 vs. USB 3.1, not the number of the USB port.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 24, 2017

howl:

But that could led to confusion, front in the leds you have USB1 and USB2 and rear in the usb ports itself you also have USB1 and USB2.

I think that I didn't notice it before having an Archer C7 where you have USB1 and USB2 both 2.0. I suppose I understood like you explain it before seeing the C7 with USB1 and 2 matching the router labels.

What you decide it's ok for me as it's cosmetics.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 24, 2017

jow-:

I'm undecided too. If we change it we probably need to change it for all models, not just for the ACS.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

mkresin:

I will fix this together with FS#425.

howl, would you please try an image from https://www.kresin.me/files/mvebu/. The images are build from the 17.01 release branch and do include LuCI.

Don't preserve your config when upgrading! Please test both usb ports with USB 2.0 and USB 3.0 devices. Check if the correct LED is switched on and report back!

The LED names should match the label printed on the case as well.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

howl:

Will try to test it today.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

howl:

Ok, I have tested it and I have found two things.

First one is that the generated led configuration had caiman instead of shelby in the led names, perhaps you hardcoded the other model to test this. I have just edited caiman to shelby and it works, USB 1 brights up when a usb 2 device is connected, and because it's only usb 2 also with a usb 3 device. USB 2 also brights up with usb 2 and 3 devices because the two ports setup in the led configuration.

The second one is that before testing with devices I set up 255 to the brightness of the leds manually in the sysfs, and found that the third led is also working. The led usb3_2 is there just below the usb3_1, it's a little point similar to the one in the ethernet port to indicate if the link is 100 or 1000 mb. Joining that we can detect if the device in the usb 3 port is 2 or 3 and that third led I have done this to the configuration:

config led 'led_usb1'
option name 'USB 1'
option sysfs 'pca963x:shelby:white:usb2'
option trigger 'usbport'
list port 'usb1-port1'

config led 'led_usb2'
option name 'USB 2'
option sysfs 'pca963x:shelby:white:usb3_1'
option trigger 'usbport'
list port 'usb2-port1'
list port 'usb3-port1'

config led 'led_usb2_2'
option name 'USB 2-2'
option sysfs 'pca963x:shelby:white:usb3_2'
option trigger 'usbport'
list port 'usb3-port1'

With it if you plug a device in USB 2, if it's 2 the bar get bright, but if it's 3 the bar and the dot below gets bright. I suppose the original firmwares does it but I haven't tested. Anyways it seems that usb3_2 is there for that purpose.

I also opened two days ago a bug in luci asking for usbport trigger configuration that is related to this use case openwrt/luci#971.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

howl:

One suggestion for the naming, I named the dot as 'USB 2-2' but it could be 'USB 2 SS', referencing SuperSpeed also as described in the first paragraph of https://en.wikipedia.org/wiki/USB_3.0 that is used as a standard de-facto like the blue color to distinguish USB 3 from 2.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

mkresin:

Indeed, I made a stupid copy/paste mistake and I wasn't ware of the usb3_2 LED.

I've fixed the copy/paste mess, added the usb3_2 LED (which is according to the usermanual used by the linksys firmware the way you supposed already) and uploaded a new images.

Would you please test again!

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 25, 2017

howl:

Tested, and it's ok. Thanks for taking into account the SS suggestion.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant