Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#454 - ARV7519RW22 physical port order #5554

Closed
openwrt-bot opened this issue Feb 2, 2017 · 7 comments
Closed

FS#454 - ARV7519RW22 physical port order #5554

openwrt-bot opened this issue Feb 2, 2017 · 7 comments
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Feb 2, 2017

howl:

With the default port order:
60 ucidef_add_switch "switch0"
61 "0:lan" "2:lan" "3:lan" "4:lan" "5:lan" "6t@eth0"

LEDE Physical
LAN 1 -> Port GE
LAN 2 -> Port 3
LAN 3 -> Port 4
LAN 4 -> Port 1
LAN 5 -> Port 2

So I think this should be set as follow:
60 ucidef_add_switch "switch0"
61 "0:lan:5" "2:lan:3" "3:lan:4" "4:lan:1" "5:lan:2" "6t@eth0"

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 2, 2017

howl:

Forget to say that LAN ports 1 to 4 are 100 mb and Port GE is 1000 mb, so instead of port 5 is labeled as GE in the router.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 2, 2017

mkresin:

So I think this should be set as follow

Do you know how to compile an image on your own to include and test the change? Or are you looking for someone who builds an Image for you with the change included?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 3, 2017

howl:

I know how to do it, but what I don't know it's if setting that numbers there make the ports to be reordered. I just supposed it because the git commit comments.

Anyways reading also this bug report https://bugs.lede-project.org/index.php?do=details&task_id=446&opened=335&type%5B0%5D=&sev%5B0%5D=&due%5B0%5D=&cat%5B0%5D=&status%5B0%5D=open&percent%5B0%5D=&reported%5B0%5D= seems that my reports are ¿disturbing? you, and I don't know why. Even if I know how to do patches or not, or I have time or not, or whatever, doesn't mind for bug reporting. If only people who provide code can report bugs just tell me and I stop right now.

But let me add two last things just to answer you with facts when you are treating as a stupid, opportunist or freeloader, or the three at the same time:
1.- At least in my situation is lack of time, if I had time, before changing trivial things like usbdev to usbport or reordering lan ports, I will bring back the ARV7519RW22 uboot code done by, I think, noltari. But in fact if I do that then it really made me stupid, because despite I have access to different router models, I only use one of them, so indeed I'm flashing them just to see if I can spot issues to help this project this way making no sense the opportunist or freeloader part. Taking apart the stupidity and making something clever, let me fix my lack of time not wasting it flashing devices I'm not going to use at all and at the same time stop bothering you.

2.- I don't know if you are going to read this because it's closed, but I point there from here just because it must be something wrong, even without testing with the device. The reason in the new comment there, https://bugs.lede-project.org/index.php?do=details&task_id=452&string=&advancedsearch=on&search_name=&type%5B0%5D=&sev%5B0%5D=&pri%5B0%5D=&due%5B0%5D=&reported%5B0%5D=&cat%5B0%5D=&status%5B0%5D=closed&percent%5B0%5D=&opened=howl&dev=&closed=&duedatefrom=&duedateto=&changedfrom=&changedto=&openedfrom=&openedto=&closedfrom=&closedto=

PD: I think the bugs I have reported are reasonable ones, and I have offer help to devs with them, according to my ability, and not just reporting, so I think your comment is senseless in this case. I also think that you are doing a very very great job, I follow regularly git commits and you are doing one of the biggest todos of lede reality (reworking the build system) with many other type of commits, but you need to rest a little and not become obsessed. Anyways, no offense, this is only my opinion.

PD 2: My English is very very bad and I tried to put into words expressions that I only know how to say in my native language, anyways I guess I have done it right and you could understand what I really tried to tell.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 3, 2017

howl:

Sorry most of the changes to the build system are from Felix Fietkau, anyways my opinion remains the same as it's still a fact that you make many other type of commits in a lot of parts, most of them, not easy ones.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 3, 2017

mkresin:

I know how to do it, but what I don't know it's if setting that numbers there make the ports to be reordered. I just supposed it because the git commit comments.

Yes the ports are ordered in LuCI based on the numbers. I'm only asking to make sure that it is tested. I don't have an ARV7519RW22 and I don't like to commit untested changes.

Long story short, the changes are tested, the port order shown in LuCI is correct with that change applied, right? Or do you prefer to test an image which includes the chance as it will be commited to LEDE?

I will bring back the ARV7519RW22 uboot code done by, I think, noltari.

It is trivial to bring back/add the ARV7519RW22 u-boot. In fact, I'm already [[https://github.com/mkresin/u-boot-lantiq/commit/937efcdc12debb3f439ad78d790b4c315ea0d01f|working on it]]. It's just that none of the devs was aware that it is missing.

But in fact if I do that then it really made me stupid, because despite I have access to different router models, I only use one of them

Well, I'm fixing bug for boards I do not have in my free time I do not really have. I guess I'm stupid.

so indeed I'm flashing them just to see if I can spot issues to help this project this way making no sense the opportunist or freeloader part. Taking apart the stupidity and making something clever, let me fix my lack of time not wasting it flashing devices I'm not going to use at all and at the same time stop bothering you.

I'm really not sure what makes you that upset. Testing LEDE on all supported devices and reporting bugs seen is what we ask the community. If you can provide a fix it is even better. We (as developer) do not have access to most of the supported devices, since the patches to add support for these boards are send by the community.

Anyway, please don't use the bugtracker for off-topic discussion. Feel free to send me a mail.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 3, 2017

howl:

Making efforts in devices you are not going to use or even you don't have is not stupid but you make it feel like it is.

With the uboot I meant not to difficult but to useful.

I agree with you that I should do this in in another medium, so I apologize for it and also I want to apologize if I misunderstood want you meant to say. Feel free to erase, edit this comments if they mess up bugtracker. Just wanted to end this with my apologizes.

Returning to the original matter if I can I will try to test what I suggested and then comment the results again.

About the uboot for arv7519rw22 I can point you the ddr-settings used by originally by gmtii to achieve the full memory of the device insted of just half of it. I tried some ago to port it also to newer uboots but there was a problem, the size with 2014.7 and newer makes uboot to write one more page corresponding to uboot cfg. I think that uboot-lantiq in lede uses compression for the xrx200 firmwares.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 3, 2017

mkresin:

About the uboot for arv7519rw22 I can point you the ddr-settings used by originally by gmtii to achieve the full memory of the device insted of just half of it. I tried some ago to port it also to newer uboots but there was a problem, the size with 2014.7 and newer makes uboot to write one more page corresponding to uboot cfg. I think that uboot-lantiq in lede uses compression for the xrx200 firmwares.

Please send me a mail with a link to or the correct ddr-settings.h. I will provide you an u-boot that will fit into the u-boot partition afterwards. If I have your mail address, I can contact you in case more u-boot testing is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant