Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#551 - leftover printf's in the new opkg (since Feb 20) #5569

Closed
openwrt-bot opened this issue Feb 22, 2017 · 2 comments
Closed

FS#551 - leftover printf's in the new opkg (since Feb 20) #5569

openwrt-bot opened this issue Feb 22, 2017 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

openwrt-bot commented Feb 22, 2017

mionica:

current LEDE opkg seems to have some leftover printfs

Example:
root@wifi-ap:~# opkg list-upgradable
alloc item for pkg=0x7e2ab0
alloc item for pkg=0x7c8900
alloc item for pkg=0x7dace0
[...]
alloc item for pkg=0x7def10
alloc item for pkg=0x7dcdd0
alloc item for pkg=0x7d4900
base-files - 172-r3554-f66a0c93b3 - 172-r3558-19720a6f03

Now, this is easily "fixed" with a
opkg list-upgradable | grep -v 'alloc item'
but a) it's still annoying, and b) should be a very quick fix

Don't know what commands this applies to (besides list-upgradable), but a quick recursive grep should probably show the extent of this inconvenience.

Also reported here: openwrt/packages#4057

@openwrt-bot
Copy link
Author

openwrt-bot commented Feb 22, 2017

mionica:

note. problem seems to be in libopkg/opkg_upgrade.c, function pkg_hash_check_installed_pkg_helper() - it's a printf

also found some ptr=%p instances in pkg_depends.c, but those are opkg_msg() calls - and I haven't seen any instances of those during normal operation

@openwrt-bot
Copy link
Author

openwrt-bot commented Feb 23, 2017

jow-:

Thank you for the report; I removed the bad printf() with https://git.lede-project.org/9e4555f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant