FS#767 - uml: Imagebuilder does not honor default packages for uml - result: no hwsim, squashfs image broken

[openwrt-bot]

glycoknob:

Stock LEDE - r4099-4c3953b

Plain UML images are fine and work. If you want to build images with the imagebuilder the default package list is not honored and modules are missing - like kmod-80211-hwsim and all related packages.

The squashfs image also does not work:
[ 0.270000] squashfs: SQUASHFS error: Filesystem uses "zlib" compression. This is not supported


profiles.mk in Imagebuilder dir seems wonky:

$ cat .profiles.mk
PROFILE_NAMES = Default
Default_NAME:=Default
Default_PACKAGES:=

.targetinfo looks okay, but I don't know:

Source-Makefile: target/linux/uml/Makefile
Target: uml
Target-Board: uml
Target-Name: User Mode Linux
Target-Arch: x86_64
Target-Arch-Packages: x86_64
Target-Features: audio ext4 source-only squashfs
Target-Depends:
Target-Optimization: -Os -pipe
CPU-Type:
Linux-Version: 4.4.61
Linux-Release: 1
Linux-Kernel-Arch: um
Target-Description:

@@
Default-Packages: base-files libc libgcc busybox dropbear mtd uci opkg netifd fstools uclient-fetch logd dnsmasq iptables ip6tables ppp ppp-mod-pppoe firewall odhcpd odhcp6c wpad-mini kmod-mac80211-hwsim mkf2fs e2fsprogs iwinfo


[openwrt-bot]

glycoknob:

Tried to find the root cause for this - this does not only affect uml but also rb532 - I guess all targets without subtargets? or profiles?

$ ./lede-imagebuilder-uml.Linux-x86_64/scripts/target-metadata.pl profile_mk .targetinfo 'rb532'
PROFILE_NAMES = Default
Default_NAME:=Default
Default_PACKAGES:=
$ ./lede-imagebuilder-uml.Linux-x86_64/scripts/target-metadata.pl profile_mk .targetinfo 'uml'
PROFILE_NAMES = Default
Default_NAME:=Default
Default_PACKAGES:=


At least hwsim works and all modules are added when I add back the default package list to Default_PACKAGES:= in .profile.mk

However squashfs.img still does not work - but without the Imagebuilder it works fine - so I guess it's another edge case for target without profiles/subtargets.

Maybe it's easier to convert the code to make it work like other targets? I attempted that but struggled with the build system.