Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#658 - umdns init error during build #5778

Closed
openwrt-bot opened this issue Mar 27, 2017 · 6 comments
Closed

FS#658 - umdns init error during build #5778

openwrt-bot opened this issue Mar 27, 2017 · 6 comments
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Mar 27, 2017

nwf:

During a build of LEDE HEAD as of right now (git describe says reboot-3906-g2a2dfb2be7), with umdns selected, during some post-configuration phase, the umdns init file is invoked and promptly fails with ".../etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory", as expected on a build machine that isn't itself running LEDE/OpenWRT.

For context, here's the surrounding lines of the build:
Configuring collectd-mod-df.
Configuring kmod-ledtrig-netdev.
Setting flags for package libc to hold.
Setting flags for package libgcc to hold.
Setting flags for package libpthread to hold.
Setting flags for package librt to hold.
make[3]: Entering directory '/tank/openwrt/scratch/builder-webserver'
make[3]: Nothing to be done for 'package/preconfig'.
make[3]: Leaving directory '/tank/openwrt/scratch/builder-webserver'
cp -fpR /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root.orig-kirkwood
/tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory
./etc/init.d/umdns: line 4: /lib/functions/network.sh: No such file or directory
sed -i "s/Installed-Time: ./Installed-Time: 1490645168/" /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/status
rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/lists/

rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/info/.postinst
rm -f /tank/openwrt/scratch/builder-webserver/build_dir/target-arm_xscale_musl_eabi/root-kirkwood/usr/lib/opkg/info/.prerm
make[2]: Leaving directory '/tank/openwrt/scratch/builder-webserver'

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 27, 2017

ffainelli:

Proposed fix:

diff --git a/package/network/services/umdns/files/umdns.init b/package/network/services/umdns/files/umdns.init index 627930b88d7f..43ff88d3d9cd 100644 --- a/package/network/services/umdns/files/umdns.init +++ b/package/network/services/umdns/files/umdns.init @@ -1,8 +1,6 @@ #!/bin/sh /etc/rc.common # Copyright (c) 2014 OpenWrt.org

-. /lib/functions/network.sh

START=80

USE_PROCD=1
@@ -31,6 +29,8 @@ reload_service() {
}

start_service() {

  •   . /lib/functions/network.sh
    
  •   local network="$(uci get umdns.@umdns[-1].network)"
    
      procd_open_instance
    

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 28, 2017

nwf:

Sorry; the git commit mentioned includes some of my (unrelated) patches; upstream is reboot-3883-g2ebfdabfbd.

That patch seems like it will do the right thing by me, but I am confused as to why the init scripts are run at all, really.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 28, 2017

rmilecki:

I am confused as to why the init scripts are run at all, really.

Same here. I don't think this fix should be needed. For me umdns builds fine, buildbots also don't //complain//. What's the output of
./scripts/diffconfig.sh
in your setup?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 30, 2017

nwf:

diffconfig output attached.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 30, 2017

rmilecki:

Your config uses ar71xx target:
CONFIG_TARGET_ar71xx=y

But the failing log comes from kirkwood target.

What's going on there?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 30, 2017

nwf:

Gah, I spaced out and ran diffconfig in the wrong directory. I'm so sorry for the noise; here's the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant