Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1005 - sysupgrade should stop network service #5953

Open
openwrt-bot opened this issue Sep 11, 2017 · 4 comments
Open

FS#1005 - sysupgrade should stop network service #5953

openwrt-bot opened this issue Sep 11, 2017 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Sep 11, 2017

pprindeville:

Supply the following if possible:

  • Device problem occurs on
  • Software versions of LEDE release, packages, etc.
  • Steps to reproduce

Applicable to all devices using the generic sysupgrade.

Seen on LEDE head.

To reproduce:

scp over a new .img file

upgrade it as "sysupgrade -v xyzzy.img"

While that's running, you'll be able to ping the router, but if you do an http connection to it, it will be reset.

What would be simpler would be doing a "/etc/init.d/network stop" just after killing off all services (including web servers).

This would make it easier to add scripting which auto-detects when the upgrade has completed by reconnecting after a reasonable wait (and retrying as necessary).

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 12, 2017

por:

Stopping the network would make it harder to investigate a failed sysupgrade ...

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 12, 2017

pprindeville:

Stopping the network would make it harder to investigate a failed sysupgrade ...

Not really. Sshd and telnetd are stopped, so you can't get in. What's the point of a box that only responds to pings and nothing else?

At least with stopping the network, you can be sure that the box won't be DoS'ed or packet-o-death'd halfway through the upgrade.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 12, 2017

bjonglez:

Actually, responding to ping is already a useful indication: it means that the device is still sysupgrading. When it stops pinging, it means that sysupgrade is done and the device is rebooting.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 12, 2017

pprindeville:

Actually, responding to ping is already a useful indication: it means that the device is still sysupgrading. When it stops pinging, it means that sysupgrade is done and the device is rebooting.

There's still the packet-o-death vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant