Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2239 - Internet LED on W8970 Not Working (18.06-SNAPSHOT r7737-6ac061f319) #6169

Closed
openwrt-bot opened this issue Apr 15, 2019 · 5 comments
Labels

Comments

@openwrt-bot
Copy link

openwrt-bot commented Apr 15, 2019

Dzanar:

I compiled from sources 18.06-SNAPSHOT r7737-6ac061f319 and internet LED not working properly. When i restart router it's not working. The trigger is set to netdev and the device is set to pppoe-wan.

config led 'led_internet'
option name 'internet'
option sysfs 'tdw89x0:green:internet'
option trigger 'netdev'
option mode 'link tx rx'
option dev 'pppoe-wan'
option default '0'

If i restart led service (/etc/init.d/led start) it works ok, but if i restart the network interfaces pppoe-wan the diode goes out until i restart again the led service.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 15, 2019

Dzanar:

Before compile i change the file target/linux/lantiq/files-4.14/arch/mips/boot/dts/TDW89X0.dtsi to fix the Wifi diode.

[[https://git.openwrt.org/?p=openwrt/staging/ynezz.git;a=blobdiff;f=target/linux/lantiq/files-4.14/arch/mips/boot/dts/TDW89X0.dtsi;h=71e051a3164057530f2d3ed1413d76a792323155;hp=233b7e33342c86f9d84c88de1ef4c37c77f09cc9;hb=8443c229f48332f9d56743f0fc6d6aff163619b6;hpb=5bc2c8eecbf73e1b58c9a2cc460d84219f682f0b|https://git.openwrt.org/?p=openwrt/staging/ynezz.git;a=blobdiff;f=target/linux/lantiq/files-4.14/arch/mips/boot/dts/TDW89X0.dtsi;h=71e051a3164057530f2d3ed1413d76a792323155;hp=233b7e33342c86f9d84c88de1ef4c37c77f09cc9;hb=8443c229f48332f9d56743f0fc6d6aff163619b6;hpb=5bc2c8eecbf73e1b58c9a2cc460d84219f682f0b]]

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 16, 2019

Dzanar:

I check that the package kmod-ledtrig-netdev is not installed. I try to install them but i can't.

root@OpenWrt:~# opkg install kmod-ledtrig-netdev
Installing kmod-ledtrig-netdev (4.9.168-1) to root...
Downloading http://downloads.openwrt.org/releases/18.06-SNAPSHOT/targets/lantiq/xrx200/packages/kmod-ledtrig-netdev_4.9.168-1_mips_24kc.ipk
Collected errors:

  • satisfy_dependencies_for: Cannot satisfy the following dependencies for kmod-ledtrig-netdev:
  •  kernel (= 4.9.168-1-aea142b55ef2b7d4ac9fbda54dc83b38)
    
  • opkg_install_cmd: Cannot install package kmod-ledtrig-netdev.
    root@OpenWrt:# uname -a
    Linux OpenWrt 4.9.168 #0 SMP Thu Apr 11 20:54:45 2019 mips GNU/Linux
    root@OpenWrt:
    #
Package kernel (4.9.168-1-c8c81c5f3dc15adcf9c6af78d3e1190e) installed in root is up to date.

After this i downloaded the image from [[http://downloads.openwrt.org/releases/18.06-SNAPSHOT/targets/lantiq/xrx200/openwrt-lantiq-xrx200-tplink_tdw8970-squashfs-sysupgrade.bin|Link]] and the internet diode is not working. After I installed the all packages named kmod-ledtrig but the diode isn't workink correct.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 20, 2019

ahmar20:

Something else is going on with the Internet LED, specially for DSL based modems I guess. I have an issue open here: [[https://bugs.openwrt.org/index.php?do=details&task_id=2193&string=Led&search_name=&type%5B0%5D=&sev%5B0%5D=&pri%5B0%5D=&due%5B0%5D=&reported%5B0%5D=&cat%5B0%5D=&status%5B0%5D=open&percent%5B0%5D=&opened=&dev=&closed=&duedatefrom=&duedateto=&changedfrom=&changedto=&openedfrom=&openedto=&closedfrom=&closedto=]]

The strange thing is that LED turns off when the link gets disconnected but it won't turn on when the link gets connected.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 22, 2019

Dzanar:

Maybe the internet stop working after this? In 18.06.2 internet LED working fine, only Wifi LED not working but it was repair in FS#2232.

[[https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=eea538204bb973d73d3bc3d38947d7f85214d486|https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=eea538204bb973d73d3bc3d38947d7f85214d486]]

EDIT:

I confirmed that internet diode stop working after this change. I compile the latest source and use this file [[https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/generic/files/drivers/leds/ledtrig-netdev.c;h=1c7c1c123a968390b3b679bfc6b34de79b43f554;hb=1c7c1c123a968390b3b679bfc6b34de79b43f554|Link]] and the internet diode working fine. Please repair this.

@openwrt-bot
Copy link
Author

openwrt-bot commented Oct 29, 2019

ms:

This change should fix the problem:
0789a9c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant