Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1479 - ramips: sysupgrade and factory images built from master after 4.14 upgrade are not built due to size #6547

Closed
openwrt-bot opened this issue Apr 9, 2018 · 6 comments
Labels

Comments

@openwrt-bot
Copy link

openwrt-bot commented Apr 9, 2018

deverton:

Trying to build a custom image for a TP-Link RE350 V1 and running into issues with the sysupgrade and factory images being too large and failing the tplink safe size check.

I can build the images with the below diffconfig, but that's obviously taking it too far as it breaks dmesg.

CONFIG_TARGET_ramips=y
CONFIG_TARGET_ramips_mt7621=y
CONFIG_TARGET_ramips_mt7621_DEVICE_re350-v1=y

CONFIG_KERNEL_CRASHLOG is not set

CONFIG_KERNEL_DEBUG_FS is not set

CONFIG_KERNEL_DEBUG_INFO is not set

CONFIG_KERNEL_DEBUG_KERNEL is not set

CONFIG_KERNEL_KALLSYMS is not set

CONFIG_KERNEL_MAGIC_SYSRQ is not set

CONFIG_KERNEL_PRINTK is not set

CONFIG_KERNEL_PRINTK_TIME is not set

CONFIG_KERNEL_SWAP is not set

CONFIG_PACKAGE_MAC80211_DEBUGFS is not set

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 9, 2018

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 22, 2018

eamaclean:

Sorry to be slow in catching this. Please apply this patch: https://gist.github.com/eamaclean/41b97c42edf26726701867f46611dfd8

I'll get this upstream shortly. The stock layout is, as you can see, rather awkward - there's a huge amount of wasted space, but freeing it will prevent rolling back to stock firmware without a full flash backup, and possibly also require relocating the MAC address in flash.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 26, 2018

deverton:

No worries about the patch time. I've tried it with my local config and still need to have KALLSYMS unset to get an image built. Given the partition layout I'm not sure what else can be done though.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 26, 2018

eamaclean:

That's odd, as it built for me with KALLSYMS enabled. Clearly I cut that a little tight.

Working on a more permanent solution than tweaking this every kernel update, for the time being you may as well just enlarge the kernel partition as needed.

@openwrt-bot
Copy link
Author

openwrt-bot commented Apr 26, 2018

deverton:

Okay, thanks, I'll double check my settings. I don't see snapshots here https://downloads.lede-project.org/snapshots/targets/ramips/mt7621/ for re350 though either.

@openwrt-bot
Copy link
Author

openwrt-bot commented Jun 26, 2018

eamaclean:

Apologies for the delay, as of 97da92b, kernel and rootfs partition sizes are automatically calculated instead of being fixed in size. A new snapshot has already been successfully built. That should be the end of this bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant