Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1670 - consistent naming convention for the imagebuilder.tar.xz URL #6618

Closed
openwrt-bot opened this issue Jul 18, 2018 · 2 comments
Closed

FS#1670 - consistent naming convention for the imagebuilder.tar.xz URL #6618

openwrt-bot opened this issue Jul 18, 2018 · 2 comments
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Jul 18, 2018

attila-lendvai:

====== context ======

i have a [[https://github.com/attila-lendvai/openwrt-auto-extroot|project/script]] that downloads imagebuilder and builds a custom OpenWRT firmware for any router. the resulting firmware automatically sets up extroot on any external storage.

====== issue ======

the URL for the image builder archive is not easily derivable. see this snippet from my script:

IMGBUILDER_NAME="lede-imagebuilder-${RELEASE}-${TARGET_ARCHITECTURE}-${TARGET_VARIANT}.Linux-x86_64"

IMGBUILDERURL="https://downloads.openwrt.org/releases/${RELEASE}/targets/${TARGET_ARCHITECTURE}/${TARGET_VARIANT}/${IMGBUILDER_ARCHIVE}"

it's easy to calculate the URL for e.g. //(ar71xx generic tl-wr1043nd-v2)// because //${TARGET_VARIANT} (i.e. 'generic')// is part of both the dir path and the filename, but not for e.g. //(bcm53xx generic dlink-dir-885l)//, because in the latter case //${TARGET_VARIANT}// is part of the directory structure, but not that of the filename itself.

====== request ======

please make sure that the imagebuilder URL can be consistently calculated from the //(arch, variant, device)// triplet, either by eliminating the variant also from the dir structure, or by consistently including it in the file name, too.

@attila-lendvai
Copy link

@attila-lendvai attila-lendvai commented Feb 21, 2022

i'm the original reporter of this issue. if i get write access to it, then i can revise it to read better on GH.

@ynezz ynezz closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants