Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1830 - Mikrotik: sysupgrade fails due to ubifs dropped support for MLC NAND flash #6827

Closed
openwrt-bot opened this issue Sep 2, 2018 · 4 comments
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Sep 2, 2018

vzahradnik:

Device problem occurs on Mikrotik RB450G and all other devices with MLC NAND flash, which use UBIFS on their flash

Affected software versions of OpenWrt/LEDE:
Issue occurrs on LEDE 17.01.5 and newer, including latest builds from trunk (dc9388a on master)

Description:
According to this message on LKML, UBIFS driver never supported MLC NAND flash and now the support was explicitly disabled. Linux kernels having this patch applied refuse to mount the UBI file system from MLC NAND mtd device.

https://lore.kernel.org/patchwork/patch/920344/

Before this patch, user could encounter data loss on such flash chip, but at least he was able to mount the filesystem. At the moment, all supported Mikrotik routers use ubifs for their flash. If user is running older openwrt/lede and performs sysupgrade to latest openwrt, the upgrade will fail and will make the router non-working, because the linux kernel will not mount the filesystem anymore. And if user tries to perform fresh install, it will also fail.

At the moment I did rollback to LEDE 17.01.4 in order to have the router at least in a working state.

  • Steps to reproduce
    Try to install latest Openwrt 18.06.1 on Mikrotik router with MLC NAND flash. Install should fail.

I think that at the moment when there's no other way (as far as I'm aware) to flash OpenWrt on Mikrotik, it would be great to patch the kernel to mount the filesystem, effectively restoring old behavior as in LEDE 17.01.4. If this is not acceptable for you, at least Wiki pages should be updated, warning users to avoid upgrading and stating LEDE 17.01.4 as the last supported version.

Attached is the log from failed Openwrt install.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 2, 2018

vzahradnik:

Attached logs.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Oct 18, 2018

xback:

Patch pushed to my staging tree.

https://git.openwrt.org/?p=openwrt/staging/xback.git;a=commit;h=8d7d4ad141fce575abe0f10939e0bb81759cfd2e

If it gets approved internally ..

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Oct 22, 2018

xback:

Hi,

Just to validate that the chip is indeed MLC,
and it's not wrongfully detected, could you please:

  • Check the board and share the exact nand flash type as printed on the chip itself?
  • Provide a full dmesg log

Thanks

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Oct 25, 2018

chunkeey:

This issue found its way to the mailing-list: [[http://lists.infradead.org/pipermail/openwrt-devel/2018-October/014324.html|[OpenWrt-Devel] [PATCH] kernel: tolerate using UBI/UBIFS on MLC flash (FS#1830)]]

And the openwrt developer Koen Vandeputte has issued an [[http://lists.infradead.org/pipermail/openwrt-devel/2018-October/014411.html
|request for serial numbers of affected RouterBoards]].

There is also a related bugreport: FS#1778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant