Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#4010 - Onion Omega2P+ reboot broken 19.07.8->21.02.0 #7034

Open
openwrt-bot opened this issue Sep 6, 2021 · 3 comments
Open

FS#4010 - Onion Omega2P+ reboot broken 19.07.8->21.02.0 #7034

openwrt-bot opened this issue Sep 6, 2021 · 3 comments
Labels
flyspray kernel release/21.02

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Sep 6, 2021

jjsantala:

This problem had gone away for most Omega2 devices in 19.07, but now its back.

See older ticket, it's probably the same thing again: https://bugs.openwrt.org/index.php?do=details&task_id=2445

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 8, 2021

tisrico:

From 19.07.8->21.02.0, mtd driver has been replaced with spi-nor, the new driver has introduced a new optional property: broken-flash-reset. If this new property is not set, the driver would not revert it back to 3 bytes mode during reset.

mtd/spi-nor/spi-nor.c: in spi_nor_scan:

if (of_property_read_bool(np, "broken-flash-reset"))
nor->flags |= SNOR_F_BROKEN_RESET;

mtd/spi-nor/spi-nor.c:

void spi_nor_restore(struct spi_nor nor)
{
/
restore the addressing mode */
if (nor->addr_width == 4 && !(nor->flags & SNOR_F_4B_OPCODES) &&
nor->flags & SNOR_F_BROKEN_RESET)
nor->params.set_4byte(nor, false);
}

https://www.kernel.org/doc/Documentation/devicetree/bindings/mtd/jedec%2Cspi-nor.txt

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 2, 2021

jjsantala:

Any idea on how to enable this on our own builds?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 18, 2021

jjsantala:

This seemed to do the trick - any change of getting this patch in:

diff --git a/target/linux/ramips/dts/mt7628an_onion_omega2.dtsi b/target/linux/ramips/dts/mt7628an_onion_omega2.dtsi
index b6d2df4756..cd41be0d4a 100644
--- a/target/linux/ramips/dts/mt7628an_onion_omega2.dtsi
+++ b/target/linux/ramips/dts/mt7628an_onion_omega2.dtsi
@@ -99,6 +99,7 @@
compatible = "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <40000000>;

  •           broken-flash-reset;
    
              partitions {
                      compatible = "fixed-partitions";
    

@aparcar aparcar added release/21.02 kernel labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray kernel release/21.02
Projects
None yet
Development

No branches or pull requests

2 participants