Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#1981 - UCI import -m failes if invoked multiple times without commit #7370

Open
openwrt-bot opened this issue Dec 2, 2018 · 0 comments
Open
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Dec 2, 2018

MOZGIII:

Hello, I'm using somewhat old LEDE, but this does not seem to make deffierence. Correct me if I'm wrong.
I installed fresh version of UCI:

root@router:~# opkg info uci
Package: uci
Version: 2018-08-11-4c8b4d6e-1
Depends: libc, libuci
Status: install user installed
Section: base
Architecture: mips_24kc
Size: 7166
Filename: uci_2018-08-11-4c8b4d6e-1_mips_24kc.ipk
Description: Utility for the Unified Configuration Interface (UCI)
Installed-Time: 1543713053

Now, the bug.
I have a small test file with some configs in it. They're named.
If I do import multiple times it results if an error.

Here's my shell log that should to reproduce this issue:

root@router:# uci commit # make sure there're no pending changes
root@router:
# rm -f /etc/config/import-test # clear the target cofnig file for a clean test
root@router:~# cat import-test # dispay the file we're about to import
config host 'a'
option name 'a'

config host 'b'
option name 'b'
root@router:# uci changes # demonstrate there're no pending changes
root@router:
# uci -m import import-test < import-test # invoke the import
root@router:# uci changes # still no changes after first import
root@router:
# uci -m import import-test < import-test # import import for the second time
root@router:# uci changes # wow, now there are some changes! this is not expected
import-test.a='host'
import-test.b='host'
root@router:
# uci -m import import-test < import-test # call import for the third time - and it fails with an error
uci: Parse error (option/list command found before the first section) at line 2, byte 1

This looks like a bug to me. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant