Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#488 - dynamic VLAN doesn't work on ath10k #7459

Open
openwrt-bot opened this issue Feb 9, 2017 · 40 comments
Open

FS#488 - dynamic VLAN doesn't work on ath10k #7459

openwrt-bot opened this issue Feb 9, 2017 · 40 comments
Labels
flyspray release/19.07

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Feb 9, 2017

czk:

Dynamic vlan config on ath10k seems not to work. Same config on ath9k works fine.

Config:

config wifi-device radio0
option type mac80211
option channel 36
option hwmode 11a
option path 'pci0000:01/0000:01:00.0'
option htmode VHT80
[...]

config wifi-iface
option device radio0
option network vlan1
option mode ap
[...]
option dynamic_vlan '1'
option 'vlan_tagged_interface' 'eth1'
option 'vlan_bridge' 'br-vlan'
option 'vlan_naming' '0'

Log:

Thu Feb 9 15:54:37 2017 daemon.err hostapd: WPA initialization for VLAN 1 failed (-1)
Thu Feb 9 15:54:37 2017 daemon.err hostapd: WPA deinit of wlan0.1 failed
Thu Feb 9 15:54:37 2017 daemon.debug hostapd: wlan0: STA ac:22:0b:a1:c7:6b IEEE 802.11: could not add dynamic VLAN interface for vlan=1

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 26, 2017

HeavyMetal:

I just tried this on my router and can see the same error for ath10k.

The ath9k radio continues to work great.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Apr 13, 2017

smunaut:

Same issue here.

Also exists in OpenWRT tracker under https://dev.openwrt.org/ticket/22369

And there is a mailing list thread http://www.spinics.net/lists/hostap/msg01650.html

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jun 24, 2017

corrideat:

I have a TP-Link Archer C7 v. 2.0, running LEDE Reboot 17.01.2 r3435-65eec8bd5f, and I can confirm this issue with the ath10k 5GHz radio, and how the exact same configuration works with ath9k.

A note to the devlopers: I'd love to see this fixed. Even though I'm probably not qualified to touch the internals of //hostapd// to resolve this (without breaking other things), I'd be happy to provide any help I can.

EDIT (2017-06-25): I have created [[https://mega.nz/#!NbxjAK6Q!rlYKJAsJFKBAJFjTLXacXlyY7saqvl1vv-UURmKqUr0|a patched wpad package]] based on this [[https://patchwork.ozlabs.org/patch/621648/|hostapd patch]]. Although the network 'works' after using this modified wpad package, mind the [[https://lists.infradead.org/pipermail/hostap/2016-May/035693.html|potential repercusions]]. It would seem like the best approach would be to actually fix this at the driver level.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jun 25, 2017

HeavyMetal:

I would want to see this fixed also.

My router is also the TP-Link Archer C7 v2.0

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 29, 2017

trey:

I can also confirm that ath9k works, ath10k does not with LEDE 17.01.2.

With OpenWRT 15.05.1 both work.

I think the VLAN feature is really important, but this is only my view. Any suggestions what a user can do, to get Qualcomm producing better drivers? Has Felix any idea or e-mail address where I can complain?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 30, 2017

corrideat:

It'd seem the issue is, in fact, getting better drivers (or firmware) from Qualcomm.

See greearb/ath10k-ct#13

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jun 7, 2018

HeavyMetal:

I just compiled the latest snapshot "OpenWrt SNAPSHOT, r7135-a0a616e" and this issue is still there.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jul 19, 2018

Actaz:

Not fixed in 17.01.5

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Aug 27, 2018

hmronline:

I can confirm this issue still exists on OpenWrt 18.06.1, for both ath10k and ath10k-ct drivers.
ath9k works fine with the same config.

Tested it with TP-Link Archer C7 v2.0.

Related:

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 28, 2018

robimarko:

This is not an OpenWrt bug, but ath10k since there is no support for them in ath10k so far.
Patch for it has just been submitted couple of days ago.
http://lists.infradead.org/pipermail/ath10k/2018-November/012542.html

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 3, 2018

chrislimpach:

The http://lists.infradead.org/pipermail/ath10k/2018-November/012542.html works for me. With it, I get dynamic vlans on ath10k (on a TP-Link Archer A7).

I had to fix it up a little bit, and locate the matching mac80211 changes, and update the firmware. I've only updated the firmware for my device.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 17, 2018

HeavyMetal:

I have tried the patch above from Christian Limpach but I am getting the errors below.

Device I am trying on is TP-Link Archer C7 v2 using the 18.06.1 branch.

Mon Dec 17 13:39:37 2018 daemon.info hostapd: wlan0: STA c0:ee:fb:aa:bb:cc IEEE 802.11: authenticated Mon Dec 17 13:39:37 2018 daemon.info hostapd: wlan0: STA c0:ee:fb:aa:bb:cc IEEE 802.11: associated (aid 1) Mon Dec 17 13:39:37 2018 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-STARTED c0:ee:fb:aa:bb:cc Mon Dec 17 13:39:37 2018 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-PROPOSED-METHOD vendor=0 method=1 Mon Dec 17 13:39:37 2018 daemon.err hostapd: WPA deinit of wlan0.3 failed Mon Dec 17 13:39:40 2018 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-RETRANSMIT2 c0:ee:fb:aa:bb:cc

Edit: I have git cloned his repo instead of manually patching it is working.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 1, 2019

hmronline:

So is this already included in openwrt source code ?

I will be glad to build a firmware based on master branch and report back if it is working or not.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 12, 2019

sameerz:

I'm also affected by this bug. Was hoping 18.06.2 would have included a fix for it, but it doesn't appear to.

Linksys EA8500 (Qualcomm Atheros QCA9980).

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 21, 2019

hmronline:

I can confirm it is still not working. Tested with a custom firmware built from master branch.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jun 3, 2019

HeavyMetal:

I am still using the patch above as it is not in the mainstream yet.

Are there any plans to merge the patch?

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jul 4, 2019

hmronline:

It has been a couple years since it was initially reported, patches were available, yet none was merged for OpenWrt.

Maybe there is a reason for not resolving this, but didn't hear why so far.

Could any body help us ?

Thanks!

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Aug 24, 2019

NerdyProjects:

It has been fixed upstream some months ago and changes made it back to openwrt trunk (e.g. NOT 18.06.4 but the 5.3 backports which get used in current git HEAD (~2019-08)).

I can confirm dynamic vlan working out of the box when you compile current openwrt but you have to use ath10k instead of ath10k-ct (which became the default), also a more recent firmware (non-ct version as the ct firmwares don't seem to support the single packet raw tx mode). There is a bug open at the ct firmware as well, they might include it at some point.

Now the downside:
I have much increased ping times (~25ms) and very low throughput (<10 Mbit/s with 2x2, 80 MHz @-70dBm) with ath10k from OpenWrt SNAPSHOT r10848-4346de8d34 so this state is unusable.

I might apply the patches specifically to 18.06.4 and try again, but maybe not now :-)

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Aug 25, 2019

NerdyProjects:

Okay, the 19.07 branch does not include the patches yet, but is already on ath10k-ct.

So:

  • See the attached patch (to be put into package/kernel/mac80211/patches/ath) for an updated version that applies to 19.07
  • Switch from ath10k-ct to ath10k, same for the firmware

It works for me without performance degradation.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 23, 2019

tomkep:

This still does not work on Archer C7 v5 on 18.06.5:

Sat Nov 23 13:44:06 2019 daemon.info hostapd: wlan0: STA 44:85:00:83:89:89 IEEE 802.11: authenticated
Sat Nov 23 13:44:06 2019 daemon.info hostapd: wlan0: STA 44:85:00:83:89:89 IEEE 802.11: associated (aid 1)
Sat Nov 23 13:44:06 2019 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-STARTED 44:85:00:83:89:89
Sat Nov 23 13:44:06 2019 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-PROPOSED-METHOD vendor=0 method=1
Sat Nov 23 13:44:06 2019 daemon.err hostapd: WPA initialization for VLAN 10 failed (-1)
Sat Nov 23 13:44:06 2019 daemon.err hostapd: WPA deinit of wlan0.10 failed
Sat Nov 23 13:44:09 2019 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-RETRANSMIT2 44:85:00:83:89:89
Sat Nov 23 13:44:15 2019 daemon.notice hostapd: wlan0: CTRL-EVENT-EAP-RETRANSMIT2 44:85:00:83:89:89

Own build with:

make PROFILE=archer-c7-v5 FILES=openwrt-01 PACKAGES="-dnsmasq -firewall -iptables -ip6tables -kmod-ip6tables -kmod-ipt-conntrack -kmod-ipt-core -kmod-ipt-nat -kmod-nf-conntrack -kmod-nf-conntrack6 -kmod-nf-ipt -kmod-nf-ipt6 -kmod-nf-nat -kmod-ppp -kmod-pppoe -kmod-pppox -kmod-slhc -libip4tc -libip6tc -libxtables -odhcp6c -odhcpd -odhcpd-ipv6only -ppp -ppp-mod-pppoe -wpad-mini wpad uhttpd luci-mod-admin-full luci-proto-ipv6 luci-theme-bootstrap libiwinfo-lua rsync -ath10k-firmware-qca988x ath10k-firmware-qca988x-ct -kmod-ath10k kmod-ath10k-ct" image

on: openwrt-imagebuilder-18.06.5-ar71xx-generic.Linux-x86_64.tar.xz

I cannot also see it working on 19.07.0-rc1.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 27, 2019

tomkep:

It still doesn't work on 18.06.5 & 19.07.0-rc1.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 27, 2019

ynezz:

Tomek, you should reproduce it first with the prebuild images from openwrt.org, then try building your own images.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 5, 2019

Hakujou:

Just tried this with latest snapshot on Archer C7 v4 (r11618-416d2cc71e), the issue still occurs.

Wiphy phy0
max # scan SSIDs: 16
max scan IEs length: 199 bytes
max # sched scan SSIDs: 0
max # match sets: 0
max # scan plans: 1
max scan plan interval: -1
max scan plan iterations: 0
Retry short limit: 7
Retry long limit: 4
Coverage class: 0 (up to 0m)
Device supports AP-side u-APSD.
Available Antennas: TX 0x7 RX 0x7
Configured Antennas: TX 0x7 RX 0x7
Supported interface modes:
* IBSS
* managed
* AP
* monitor
* mesh point
* P2P-client
* P2P-GO
* P2P-device

AP/VLAN capability is not reported. Swapping CT to non-CT firmware solved the issue, dynamic vlan works on qc9980.

Will try tomorrow on 9984 and report back.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 6, 2019

Hakujou:

It works on 9984 without swapping firmware. Tried on both RC2 and today's snapshot.
Installing the non-CT driver on 9984 has the opposite behaviour : AP/VLAN capability disappears.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 8, 2019

HeavyMetal:

I compiled OpenWrt 19.07.0-rc2, r10775-db8345d8e4 on ipq40xx gl-b1300 with non-CT firmware / driver and it didnt work.

daemon.err hostapd: Failed to create interface wlan1.5: -95 (Not supported)

After compiling OpenWrt SNAPSHOT, r11631-deb835849a with non-CT firmware / driver it is working fine.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jan 10, 2020

tomkep:

It still doesn't work on https://downloads.openwrt.org/releases/19.07.0/targets/ar71xx/generic/openwrt-19.07.0-ar71xx-generic-archer-c7-v5-squashfs-factory.bin. I've only replaced wpad-basic with wpad.

Sat Jan 11 00:52:04 2020 daemon.err hostapd: Failed to create interface wlan0.10: -122 (Not supported)

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jan 28, 2020

imac:

Just discovered this on 19.07.0

Tue Jan 28 17:41:14 2020 daemon.err hostapd: Failed to create interface wlan0.81: -122 (Not supported)
Tue Jan 28 17:41:17 2020 daemon.err hostapd: Failed to create interface wlan0.81: -122 (Not supported)
Tue Jan 28 17:41:21 2020 daemon.err hostapd: Failed to create interface wlan0.81: -122 (Not supported)

Archer C7v2 ath79 target:
[ 16.007715] ath10k_pci 0000:00:00.0: firmware ver 10.1-ct-8x-__fW-022-b0e1b7cd api 2 features wmi-10.x,has-wmi-mgmt-tx,mfp,txstatus-noack,wmi-10.x-CT,ratemask-CT,txrate-CT,get-temp-CT,tx-rc-CT,cust-stats-CT,retry-gt2-CT,txrate2-CT,beacon-cb-CT,wmi-block-ack-CT crc32 1e527180

Only the Ath10k is failing. 2.4G radio is fine. Rolling back to 18.06 for now.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jan 28, 2020

imac:

iw list

Wiphy phy0
...
Supported interface modes:
* IBSS
* managed
* AP
* monitor
* mesh point
* P2P-client
* P2P-GO
* P2P-device

"* AP/VLAN" is notably missing from the interface modes supported by Ath10k on 19.07.0

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jan 28, 2020

imac:

Some upstream discussion, fixed in some other CT firmware, but possibly Ath10k being left behind.. greearb/ath10k-ct#72

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 13, 2020

imac:

It looks like a small amount of work might be required, or that the patches are just waiting to flow through.. not clear as this commit seems to be related:
commit 92953ae
Author: Koen Vandeputte koen.vandeputte@ncentric.com
Date: Tue Sep 24 11:58:54 2019 +0200

ath10k-ct: update to version 2019-09-09

5e8cd86f90da ath10k-ct: Backport ap-vlan code from 5.2 to 4.20 and 4.19 drivers.
0c518586bd7f ath10k-ct: Fix a few warning splats.

Adds AP VLAN.
Refreshed all patches.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 24, 2020

trey:

I also tried yesterday to get dynamic vlan running with 19.07.1.

Both versions of the ath10k driver (ct and non ct) still have the same error:

daemon.err hostapd: Failed to create interface wlan0.70: -95 (Not supported)

Could we do anything that someone would fix the problem in openwrt ?! Any need for a ath10k card for the openwrt developer???

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 27, 2020

arthurand:

Installed 19.07.2 on my Archer C7 V2 and I confirm that AP/VLAN option is unfortunately still missing

Supported interface modes:
* IBSS
* managed
* AP
* monitor
* mesh point
* P2P-client
* P2P-GO
* P2P-device

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Dec 9, 2020

jnahmias:

Works for me on a Netgear R7800 running 19.07.4:

root@OpenWrt:~# iw phy
Wiphy phy1
max # scan SSIDs: 16
max scan IEs length: 195 bytes
max # sched scan SSIDs: 0
max # match sets: 0
max # scan plans: 1
max scan plan interval: -1
max scan plan iterations: 0
Retry short limit: 7
Retry long limit: 4
Coverage class: 0 (up to 0m)
Device supports AP-side u-APSD.
Available Antennas: TX 0xf RX 0xf
Configured Antennas: TX 0xf RX 0xf
Supported interface modes:
* IBSS
* managed
* AP
* AP/VLAN
* monitor
* mesh point
* P2P-client
* P2P-GO
* P2P-device

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 22, 2021

imac:

Noticed that ath10k wave-1 radios on 19.07.7 still have not seen the patch that should make this work, thought some are sucessfully building on C7v5, so seems possible

greearb/ath10k-ct#155

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Feb 22, 2021

imac:

So it looks like all that remains is to check for the CT feature required for support.

ATH10K_FW_FEATURE_CONSUME_BLOCK_ACK_CT

where the stock firmware is checked for

WMI_SERVICE_PER_PACKET_SW_ENCRYPT

Per the comments in greearb/ath10k-ct#72

The shortcut is to just hack out the decision to remove the AP/VLAN feature as shown below.

-- a/ath10k-4.19/mac.c
+++ b/ath10k-4.19/mac.c
9998,10001c9998,9999
< if (test_bit(WMI_SERVICE_PER_PACKET_SW_ENCRYPT, ar->wmi.svc_map)) {
< ar->hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
< ar->hw->wiphy->software_iftypes |= BIT(NL80211_IFTYPE_AP_VLAN);
< }

  ar->hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN);
  ar->hw->wiphy->software_iftypes |= BIT(NL80211_IFTYPE_AP_VLAN);</code>

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 20, 2021

imac:

Working in current snapshot on Ath10k wave1 radios, so maybe see in 19.07.8

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Mar 21, 2021

arthurand:

What is your router model and version? Have you downloaded the unmodified snapshot? In iw list it shows the AP/VLAN capability on the 5GHz interface?

I also tried switching drivers on the 19.07.2 but it didn't help.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Apr 22, 2021

tomkep:

It looks like it is working, after very long wait, on 21.02.0-rc1 on TP-link Archer C7 v5.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Sep 20, 2021

arthurand:

After a very long wait it is working on TP-Link Archer C7 v5 running 21.02.0 stable, will test on TP-Link Archer C7 v2 soon.

@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Jan 14, 2022

augenblickliebhaber:

I want to use dynamic VLAN with a APU2 board with Compex WLE600VX wlan card (also ath10k driver).
Is it working in openwrt 21.02.1?

@aparcar aparcar added the release/19.07 label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/19.07
Projects
None yet
Development

No branches or pull requests

2 participants