Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#2792 - lantiq DSL statuistics and diagnostics do not report G.INP Retransmission counters #7595

Closed
openwrt-bot opened this issue Jan 31, 2020 · 3 comments
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release

Comments

@openwrt-bot
Copy link

openwrt-bot commented Jan 31, 2020

moeller0:

OpenWrt 19.07.1 on BT HomeHub5A (lantiq vrx200) the dsl stats report tool (ltq-vdsl-app_4.17.18.6-2_mips_24kc.ipk) and the matching kerel module (kmod-ltq-vdsl-vr9-mei_4.14.167+1.5.17.6-4_mips_24kc.ipk) do not report ITU G.998.4 Retransmission counts (on lines using G.INP retransmissions. It turns out that adding:
CONFIGURE_ARGS += \
--enable-dsl-pm-retx-counters \
--enable-dsl-pm-retx-thresholds

to openwrt/package/kernel/lantiq/ltq-vdsl/Makefile and openwrt/package/network/config/ltq-vdsl-app/Makefile and rebuilding yields a working ReTx counter report:

root@BTHH5A:# . /lib/functions/lantiq_dsl.sh ; dsl_cmd rtsg 0
nReturn=0 nDirection=0 nRxCorruptedTotal=0 nRxUncorrectedProtected=0 nRxRetransmitted=0 nRxCorrected=0 nTxRetransmitted=3
root@ BTHH5A:
# . /lib/functions/lantiq_dsl.sh ; dsl_cmd rtsg 1
nReturn=0 nDirection=1 nRxCorruptedTotal=7114893 nRxUncorrectedProtected=6171968 nRxRetransmitted=0 nRxCorrected=942925 nTxRetransmitted=9228892

At least in Germany the incumbent uses G.998.4 Retransmission, not only do deal with impulse noise, but also as a diagnostic counters for its Dynamik Link/Spektrum Management tool that based on these and other counters will limit the maximum perissable Sync for each line to optimize lik stability. It would be really great if stock OpenWrt builds would alow to report these values and I would like to propose to change the makefiles as shown above.

@openwrt-bot
Copy link
Author

openwrt-bot commented Mar 14, 2020

moeller0:

Here is a patch to get the required changes into the two relevant packages:
diff --git a/package/kernel/lantiq/ltq-vdsl/Makefile b/package/kernel/lantiq/ltq-vdsl/Makefile
index cf3711beb7..e42f191343 100644
--- a/package/kernel/lantiq/ltq-vdsl/Makefile
+++ b/package/kernel/lantiq/ltq-vdsl/Makefile
@@ -69,6 +69,10 @@ CONFIGURE_ARGS += --enable-model=full
#CONFIGURE_ARGS += --enable-model=typical
#CONFIGURE_ARGS += --enable-model=debug

+CONFIGURE_ARGS += \

  • --enable-dsl-pm-retx-counters \
  • --enable-dsl-pm-retx-thresholds

define Build/InstallDev
$(INSTALL_DIR) $(1)/usr/include/drv_vdsl_cpe_api
$(CP) $(PKG_BUILD_DIR)/src/include/drv_dsl_cpe*.h $(1)/usr/include/drv_vdsl_cpe_api/
diff --git a/package/network/config/ltq-vdsl-app/Makefile b/package/network/config/ltq-vdsl-app/Makefile
index e2ecefa258..c5a96b5a51 100644
--- a/package/network/config/ltq-vdsl-app/Makefile
+++ b/package/network/config/ltq-vdsl-app/Makefile
@@ -56,6 +56,9 @@ CONFIGURE_ARGS +=
--enable-model=typical
--enable-dsl-pm-showtime
--disable-dsl-ceoc
+CONFIGURE_ARGS += \

  • --enable-dsl-pm-retx-counters \
  • --enable-dsl-pm-retx-thresholds
    #CONFIGURE_ARGS += --enable-model=debug

define Package/ltq-vdsl-app/install

@aparcar aparcar added the release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release label Feb 22, 2022
@xdarklight
Copy link
Contributor

xdarklight commented Mar 15, 2022

As far as I can tell this has been fixed with 48162e4 which will go into OpenWrt 22.x

@moeller0
Copy link

moeller0 commented Mar 23, 2022

Can be closed then!

@mkresin mkresin closed this as completed Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray release/19.07 pull request/issue targeted (also) for OpenWrt 19.07 release
Projects
None yet
Development

No branches or pull requests

5 participants