Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#50 - No image or non-verbose output created if image is too big #7604

Closed
openwrt-bot opened this issue Jul 13, 2016 · 4 comments
Closed
Labels

Comments

@openwrt-bot
Copy link

openwrt-bot commented Jul 13, 2016

stefanct:

The target/install target does not produce the *squashfs-factory.bin and *squashfs-sysupgrade.bin binaries if the images are too big to fit the selected flash size.
However, make doesn't say a word to the user but simply does not produce the files. The user has to either check the mtime of the files if they were created earlier or use make target/install V=s to derive what's wrong.
According to jow on IRC this is just an artifact of no way to bypass silent mode. That might be the common explanation but it is still a bug from my POV.

@openwrt-bot
Copy link
Author

openwrt-bot commented Mar 3, 2017

lemoer:

I would also like to see this fixed, because it's very annoying to spend hours in debugging elsewhere because the build was "successful".

In my opinion, the priority should be changed a little higher than "very low". ;)

@openwrt-bot
Copy link
Author

openwrt-bot commented Mar 3, 2017

hnyman:

It might be finally possible to "fix" this, the there is now the separate CONFIG_BUILDBOT symbol in LEDE.

In buildbot the build needs to fail silently and the build should continue, as the other images from the same target need to be built, even if one router fails.

But I guess that in private builds (when CONFIG_BUILDBOT is not set), the failure might be seen as more fatal and could stop the build process.

The silently failing builds due to "too big" has been a frequent topic in forums, so fixing this might help a lot of people.

@openwrt-bot
Copy link
Author

openwrt-bot commented Mar 3, 2017

lemoer:

I think it would be better to introduce a state "image failed", where the build process continues building other images and targets. At the end of the build process, it should print:

The following images have failed: - ar71xx-generic - TP-Link TL-WR841N/ND v11 (images are too big by 53912 bytes) - ... - ...

and exit with unclean exit code.

@openwrt-bot
Copy link
Author

openwrt-bot commented Feb 3, 2020

urjaman:

Poke. I also think this should have some priority that is higher than "Very Low", because this caused long confusion in my work - i thought i hadnt turned on a knob necessary to make the factory & sysupgrade images, but instead they were just too big and not made...

aparcar added a commit to aparcar/openwrt that referenced this issue Feb 28, 2022
If a image is bigger than the device can handle, an error message is
printed. This is usually silenced and silently ignored, making it harder
to debug. While it's possible to run the build in verbose mode (via
`make V=s`) and grep for *is too big*, it's more intuitive to print the
error message directly. For that use the newly unlocked `$(call
ERROR_MESSAGE,...)` definition which now also print in non-verbose mode.

Fixes: FS#50 (aka openwrt#7604)

Signed-off-by: Paul Spooren <mail@aparcar.org>
aparcar added a commit to aparcar/openwrt that referenced this issue Feb 28, 2022
If a image is bigger than the device can handle, an error message is
printed. This is usually silenced and silently ignored, making it harder
to debug. While it's possible to run the build in verbose mode (via
`make V=s`) and grep for *is too big*, it's more intuitive to print the
error message directly. For that use the newly unlocked `$(call
ERROR_MESSAGE,...)` definition which now also print in non-verbose mode.

Fixes: FS#50 (aka openwrt#7604)

Signed-off-by: Paul Spooren <mail@aparcar.org>
jow- pushed a commit that referenced this issue Feb 28, 2022
If a image is bigger than the device can handle, an error message is
printed. This is usually silenced and silently ignored, making it harder
to debug. While it's possible to run the build in verbose mode (via
`make V=s`) and grep for *is too big*, it's more intuitive to print the
error message directly. For that use the newly unlocked `$(call
ERROR_MESSAGE,...)` definition which now also print in non-verbose mode.

Fixes: FS#50 (aka #7604)

Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar aparcar closed this as completed Feb 28, 2022
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this issue Mar 2, 2022
If a image is bigger than the device can handle, an error message is
printed. This is usually silenced and silently ignored, making it harder
to debug. While it's possible to run the build in verbose mode (via
`make V=s`) and grep for *is too big*, it's more intuitive to print the
error message directly. For that use the newly unlocked `$(call
ERROR_MESSAGE,...)` definition which now also print in non-verbose mode.

Fixes: FS#50 (aka openwrt#7604)

Signed-off-by: Paul Spooren <mail@aparcar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants