FS#3346 - Ubox invalid memory access (does not build with gcc10)

[openwrt-bot]

MartB:

See: https://git.openwrt.org/?p=project/ubox.git;a=blob;f=kmodloader.c;h=6f06ee3939f2f3e151357d33cfd165603cb40e4d;hb=HEAD#l699

Prints:
In function 'main_insmod',
inlined from 'main' at /home/openwrt/openwrt-lam/build/archer-c7-v2eu/build_dir/target-mips_24kc_musl/ubox-2019-12-31-0e34af14/kmodloader.c:1062:10:
/home/openwrt/openwrt-lam/build/archer-c7-v2eu/build_dir/target-mips_24kc_musl/ubox-2019-12-31-0e34af14/kmodloader.c:734:13: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
734 | options[0] = 0;
| ~~~~~~~~~~~^~~
/home/openwrt/openwrt-lam/build/archer-c7-v2eu/build_dir/target-mips_24kc_musl/ubox-2019-12-31-0e34af14/kmodloader.c: In function 'main':
/home/openwrt/openwrt-lam/build/archer-c7-v2eu/build_dir/target-mips_24kc_musl/ubox-2019-12-31-0e34af14/kmodloader.c:727:12: note: at offset 0 to an object with size 0 allocated by 'malloc' here
727 | options = malloc(len);
| ^~~~~~~~~~~

Fix im using for my builds is attached.

Kind regards
MartB

[openwrt-bot]

MartB:

Just to clarify a bit more, malloc(0) is actually implementation dependent, so it should better be avoided.