Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS#4150 - ./script/feeds does not return error on failure #9137

Open
openwrt-bot opened this issue Nov 22, 2021 · 1 comment
Open

FS#4150 - ./script/feeds does not return error on failure #9137

openwrt-bot opened this issue Nov 22, 2021 · 1 comment
Labels

Comments

@openwrt-bot
Copy link

@openwrt-bot openwrt-bot commented Nov 22, 2021

luizluca:

Hello,

Script feeds always returns 0, no matter if it did what it was asked to or not

$ ./scripts/feeds install foobar && echo ok || echo err WARNING: No feed for package 'foobar' found ok
@openwrt-bot
Copy link
Author

@openwrt-bot openwrt-bot commented Nov 27, 2021

hnyman:

Script feeds always returns 0

Not quite true.
The return value logic depends on the command used. For example, the "update" command was patched by me in 2015 to provide an error on failed feed updates.

Based on the source code, also the package install step usually provides an error code, with the exception of the case that you encountered: no feed found. Then there is plain "return 0" despite the error condition.

https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L597-L613

(The same situation seems to be with the subfunction install_src: https://github.com/openwrt/openwrt/blob/master/scripts/feeds#L523-L524 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant