Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips: mt7688 watchdog register base addr bug #1035

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@lbzhung
Copy link
Contributor

lbzhung commented Jun 11, 2018

Hi,

I found MT7688 watchdog not work, in mt7628an.dtsi file the wathcdog reg base addr is 0x120,

	watchdog: watchdog@120 {
		compatible = "ralink,mt7628an-wdt", "mediatek,mt7621-wdt";
		reg = <0x120 0x10>;

but linux kernel driver mt7621_wdt.c use base addr is 0x100,

    #define TIMER_REG_TMRSTAT		0x00
    #define TIMER_REG_TMR1LOAD		0x24
    #define TIMER_REG_TMR1CTL	0x20

so i modify the mt7628an.dtsi use base addr 0x100.

@neheb

This comment has been minimized.

Copy link
Contributor

neheb commented Jun 11, 2018

Commit needs Signed-off-by at the end. Use:

git commit --signoff

when making commits. For this one, add --amend and then:

git push --force

FIX ramips mt7688 watchdog register base addr bug
Signed-off-by: lbzhung <gewalalb@gmail.com>

@lbzhung lbzhung force-pushed the lbzhung:master branch from 551275a to f241f94 Jun 13, 2018

@lbzhung

This comment has been minimized.

Copy link
Contributor Author

lbzhung commented Jun 13, 2018

Thank you. I've modified it.

@mkresin mkresin self-assigned this Jun 15, 2018

@mkresin

This comment has been minimized.

Copy link
Member

mkresin commented Jun 16, 2018

merged, thanks! Please add a commit message to your commit the next time. This time I've done it.

@mkresin mkresin closed this Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.