Jump to conversation
Unresolved conversations (11)
@csharper2005 csharper2005 May 22, 2023
Would you like to sort the blocks alphabetically? 4, 24, 2a.
Outdated
...tek/dts/mt7986a-zyxel-ex5601-t0-stock.dts
pameruoso
@Ansuel Ansuel May 21, 2023
Is nvmem cell not supported by the network driver? considering Factory is a partition, data is binary... no sense to use board.d script when you can use dts directly to reference them. Same comment for the wifi
Outdated
...filogic/base-files/etc/board.d/02_network
pameruoso csharper2005
@csharper2005 csharper2005 May 18, 2023
`Zyxel_EX5601-T0-stock` Lower case is more usual.
Outdated
target/linux/mediatek/image/filogic.mk
pameruoso
@csharper2005 csharper2005 May 18, 2023
Are the `eth0` and `eth1` mac addresses correct?
Outdated
...mediatek/dts/mt7986a-zyxel-ex5601-t0.dtsi
pameruoso
@csharper2005 csharper2005 May 18, 2023
You can use `GPIO_ACTIVE_HIGH` instead of `0` and `GPIO_ACTIVE_LOW` instead of `1`.
Outdated
...mediatek/dts/mt7986a-zyxel-ex5601-t0.dtsi
pameruoso
@csharper2005 csharper2005 May 18, 2023
Does non NAND version of the EX5601-T0 also exist?
Outdated
target/linux/mediatek/image/filogic.mk
pameruoso
@csharper2005 csharper2005 May 18, 2023
Lower case would be better.
Outdated
target/linux/mediatek/image/filogic.mk
pameruoso
@csharper2005 csharper2005 May 18, 2023
This line can be dropped.
Outdated
...mediatek/dts/mt7986a-zyxel-ex5601-t0.dtsi
pameruoso
@csharper2005 csharper2005 May 18, 2023
This line can be dropped.
Outdated
...mediatek/dts/mt7986a-zyxel-ex5601-t0.dtsi
pameruoso
@csharper2005 csharper2005 May 18, 2023
This line can be dropped.
Outdated
...mediatek/dts/mt7986a-zyxel-ex5601-t0.dtsi
pameruoso
@csharper2005 csharper2005 May 11, 2023
Please add a newline at the end.
Outdated
...mediatek/dts/mt7986a-zyxel-EX5601-T0.dtsi
pameruoso csharper2005
Resolved conversations (3)
@Ansuel Ansuel May 22, 2023
extra space?
...tek/dts/mt7986a-zyxel-ex5601-t0-stock.dts
pameruoso
@Ansuel Ansuel May 22, 2023
extra space?
...tek/dts/mt7986a-zyxel-ex5601-t0-stock.dts
pameruoso
@csharper2005 csharper2005 May 18, 2023
I suggest make this `read-only` or add `uboot-env` config. The same for the other partitions those aren't `read-only` and aren't used by OpenWrt.
...tek/dts/mt7986a-zyxel-ex5601-t0-stock.dts
pameruoso