-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
build: set PATH for post-install scripts #16865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Nov 5, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the post-install script won't fail in case the package is included in the rootfs image. Requires openwrt/openwrt#16865 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
|
Looks reasonable, please proceed |
|
@dangowrt worth to backport? |
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
6566166 to
21b5ac8
Compare
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Nov 5, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the post-install script won't fail in case the package is included in the rootfs image. Requires openwrt/openwrt#16865 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
goldwrt
pushed a commit
to goldwrt/openwrt
that referenced
this pull request
Nov 5, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
robimarko
pushed a commit
to dangowrt/packages
that referenced
this pull request
Nov 7, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the post-install script won't fail in case the package is included in the rootfs image. Requires openwrt/openwrt#16865 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Nov 7, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the post-install script won't fail in case the package is included in the rootfs image. Requires openwrt/openwrt#16865 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
added a commit
to dangowrt/packages
that referenced
this pull request
Nov 9, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the post-install script won't fail in case the package is included in the rootfs image. Requires openwrt/openwrt#16865 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 13, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 14, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 14, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Ra2-IFV
pushed a commit
to Ra2-IFV/openwrt
that referenced
this pull request
Nov 14, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
liudf0716
pushed a commit
to liudf0716/openwrt
that referenced
this pull request
Dec 5, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Dec 11, 2024
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
M3m3M4n
pushed a commit
to M3m3M4n/openwrt
that referenced
this pull request
Feb 16, 2025
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
HateTM
pushed a commit
to HateTM/tplink_archer-ax80-v1
that referenced
this pull request
Mar 31, 2025
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
maurerr
pushed a commit
to maurerr/openwrt
that referenced
this pull request
Apr 9, 2025
post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk. Set PATH for post-install scripts to TARGET_PATH_PKG. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Link: openwrt#16865 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKGwhich is not part of the PATH set toTARGET_PATHin rules.mk.Set
PATHfor post-install scripts toTARGET_PATH_PKG.