Skip to content

build: set PATH for post-install scripts #16865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

dangowrt
Copy link
Member

@dangowrt dangowrt commented Nov 5, 2024

post-install scripts may need to call executables installed to STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

dangowrt added a commit to dangowrt/packages that referenced this pull request Nov 5, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the
post-install script won't fail in case the package is included in the
rootfs image.

Requires openwrt/openwrt#16865

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
@github-actions github-actions bot added the build/scripts/tools pull request/issues for build, scripts and tools related changes label Nov 5, 2024
@aparcar
Copy link
Member

aparcar commented Nov 5, 2024

Looks reasonable, please proceed

@Ansuel
Copy link
Member

Ansuel commented Nov 5, 2024

@dangowrt worth to backport?

post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
@Ansuel Ansuel force-pushed the post-install-path-pkg branch from 6566166 to 21b5ac8 Compare November 5, 2024 10:21
@openwrt-bot openwrt-bot merged commit 21b5ac8 into openwrt:main Nov 5, 2024
5 checks passed
dangowrt added a commit to dangowrt/packages that referenced this pull request Nov 5, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the
post-install script won't fail in case the package is included in the
rootfs image.

Requires openwrt/openwrt#16865

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
goldwrt pushed a commit to goldwrt/openwrt that referenced this pull request Nov 5, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
robimarko pushed a commit to dangowrt/packages that referenced this pull request Nov 7, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the
post-install script won't fail in case the package is included in the
rootfs image.

Requires openwrt/openwrt#16865

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt added a commit to dangowrt/packages that referenced this pull request Nov 7, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the
post-install script won't fail in case the package is included in the
rootfs image.

Requires openwrt/openwrt#16865

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt added a commit to dangowrt/packages that referenced this pull request Nov 9, 2024
Use host-build of shared-mime-info and apply IPKG_INSTROOT so the
post-install script won't fail in case the package is included in the
rootfs image.

Requires openwrt/openwrt#16865

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
vincejv pushed a commit to vincejv/openwrt that referenced this pull request Nov 13, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
vincejv pushed a commit to vincejv/openwrt that referenced this pull request Nov 14, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
vincejv pushed a commit to vincejv/openwrt that referenced this pull request Nov 14, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Ra2-IFV pushed a commit to Ra2-IFV/openwrt that referenced this pull request Nov 14, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
liudf0716 pushed a commit to liudf0716/openwrt that referenced this pull request Dec 5, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Vladdrako pushed a commit to Vladdrako/openwrt that referenced this pull request Dec 11, 2024
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
M3m3M4n pushed a commit to M3m3M4n/openwrt that referenced this pull request Feb 16, 2025
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
HateTM pushed a commit to HateTM/tplink_archer-ax80-v1 that referenced this pull request Mar 31, 2025
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
maurerr pushed a commit to maurerr/openwrt that referenced this pull request Apr 9, 2025
post-install scripts may need to call executables installed to
STAGING_DIR_HOSTPKG which is not part of the PATH set to TARGET_PATH in
rules.mk.
Set PATH for post-install scripts to TARGET_PATH_PKG.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: openwrt#16865
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/scripts/tools pull request/issues for build, scripts and tools related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants