Please update to use DEVICE_VENDOR, DEVICE_MODEL and DEVICE_VARIANT as introduced in: https://github.com/openwrt/openwrt/commit/8c3dbaf8b49233e275b2dce4e30dc0a2bf8c86c5

This block might be obsolete as gpio is not disabled elsewhere.

Update to &info if you follow my request from above.

Update to &info if you follow my request from above.

Please update both alias and label to "info". I have recently made an effort to harmonize this: 3d15332

Maybe try "gpio-keys" and remove poll-interval.

@p-wassi Please get rid of this gpio-export (deprecated for details see https://github.com/openwrt/openwrt/pull/1366#issuecomment-424834448) node as well, probably use gpio-hog for this purpose.

@p-wassi I can't see, that you're using GPIOs 0-3, so why this pinctrl? You're using GPIO 4 for reset key, so it should be different pinctrl with bit 6 (CLK_OBS4_ENABLE).

phy-mode for gmac1 is defined in ar934x.dtsi. this line should be dropped.

For this port configuration I prefer to enable both GMACs and use GMAC0 for wan port.

If I remember correctly there is a dynamic partition splitter for tplink-safeloader. Is it in ar71xx only? If so you could consider porting it to ath79. edit: I'm not sure if target/linux/generic/files/drivers/mtd/mtdsplit/mtdsplit_tplink.c works for tplink-safeloader. If it works a compatible string of "tplink,firmware" here should do the job.

this isn't needed. mtd-mac-address-increment is added only when you need it to do its job.

Should be dropped. gmac1 is connected to builtin switch and the link is fixed 1000M full duplex. phy-handle is used for polling link status from PHY.