ath79: phy-ar7200-usb: do not print error on defered init #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a chance to test this backported to 19.07 on my TL-WDR4300. |
Leo-PL
approved these changes
Feb 7, 2020
|
Spelling "On a deferd init" -> "On a defered init" Consider adding the Tested-by and sending this to the devel list to speed it up ... |
This is only a cosmetic correction, as the driver works as expected. However, the error message confuses users about a missing reset definition. On a defered init we don't see the following error message now: [ 0.078292] ar7200-usb-phy usb-phy: phy reset is missing Tested-by: Lech Perczak <lech.perczak@gmail.com> Signed-off-by: Johann Neuhauser <johann@it-neuhauser.de>
jneuhauser
force-pushed
the
phy-ar7200-usb-cosmetic-fix
branch
from
c1602d4 to
ce9a20a
Compare
|
Patched also 5.4 patch, corrected the spelling mistakes, added Tested-by @Leo-PL and sent the patch to the mailing list for wider audience. http://lists.infradead.org/pipermail/openwrt-devel/2020-April/023139.html |
|
No one is reacting on the mailing list... |
|
It's merged now, so close this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a cosmetic correction, as the driver works as expected.
However, the error message confuses users about a missing reset definition.
On a deferd init we don´t see the following error message now:
[ 0.078292] ar7200-usb-phy usb-phy: phy reset is missing
Signed-off-by: Johann Neuhauser johann@it-neuhauser.de