realtek: Add PoE support to DGS-1210-10P #3883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set power budget for DGS-1210-10P and add package to manage PoE.
Borromini
reviewed
Feb 18, 2021
| @@ -54,7 +54,7 @@ endef | |||
| define Device/d-link_dgs-1210-10p | |||
| $(Device/d-link_dgs-1210) | |||
| DEVICE_MODEL := DGS-1210-10P | |||
| DEVICE_PACKAGES += lua-rs232 | |||
| DEVICE_PACKAGES += lua-rs232 rtl83xx-poe | |||
There was a problem hiding this comment.
The rtl83xx-poe package isn't in master yet (last time I checked only in blogic's tree) so you can't have it depend on that for now (see e.g. the GS1900-10HP/8HP definitions).
There was a problem hiding this comment.
You're right it didn't pull in rtl38xx-poe. I didn't notice as I assumed it would have had some type of error when I built the image!
|
I think this needs a Signed-off-by as well just like a regular patch would. |
|
Will revisit this issue when rtl38xx-poe package becomes available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set power budget for DGS-1210-10P and add package to manage PoE.