Jump to conversation
Unresolved conversations (2)
@adschm adschm Jun 14, 2021
Is removing the declaration here intended?
.../drivers/net/ethernet/ralink/gsw_mt7620.c
mcprat nbriggs
@adschm adschm Jun 14, 2021
That's unrelated, and I think we prefer the version before the change?
...ux/ramips/dts/mt7620a_engenius_esr600.dts
adschm mcprat
Resolved conversations (6)
@nbriggs nbriggs May 30, 2021
What was going on here, that it was previously setting mediatek,port*5* ?
Outdated
...ux/ramips/dts/mt7620a_edimax_ew-747x.dtsi
mcprat adschm
@981213 981213 May 29, 2021
If you really want a fake topology, at least have the port used to connect the external switch here instead of such a random port choice.
Outdated
.../mt7620/base-files/etc/board.d/02_network
@981213 981213 May 29, 2021
this one can be assigned at line 282 where the OF property is read: ```c if (of_property_read_u16(np, "mediatek,ephy-base-address", &val) == 0) gsw->ephy_base = val; else gsw->ephy_base = 0; ```
Outdated
.../drivers/net/ethernet/ralink/gsw_mt7620.c
mcprat 981213
@981213 981213 May 29, 2021
```c gsw->port4_ephy = !of_property_read_bool(np, "mediatek,port4-gmac"); ```
Outdated
.../drivers/net/ethernet/ralink/gsw_mt7620.c
@981213 981213 May 29, 2021
Is this added by accident? If not, it should be in a separated commit.
Outdated
.../linux/ramips/dts/mt7620a_asus_rp-n53.dts
mcprat
@mcprat mcprat May 14, 2021
@blogic @nbd168 I am wondering why this line was included in the ethernet driver at all....any specific reason?
.../drivers/net/ethernet/ralink/gsw_mt7620.c
mcprat 981213