ipq806x: switch to kernel 5.10 #4525
Conversation
|
would be great to get DSA on ath79. |
|
@neheb don't have a target to test so i can only help and check what is needed to get it running |
|
Sure. I've been busy with other stuff lately so I couldn't devote as much time on this. Last I remember I couldn't get qca8k go load. It's possible this was because I was building with the wrong kernel (5.4 instead of 5.10 ...). I'll try to redo my setup sometime soon. Since then, I removed the WiFi card from my device and placed it elsewhere. For those curious: |
|
the card is a little bigger ahahah (if you want to use the other port, try to find an extension cable) anyway the not loading error is strange at least an error should be reported... the kernel should not be the cause... |
There are three slots. I don't mind if one is blocked. It is somewhat concerning that it's that close to the CPU.
Hmm good point. I remember looking through dmesg and not finding qca8k anywhere. |
|
the driver check the switch id... in some old version it was silent and didn't produce any error... now it should report if it does detect an invalid id and fail to probe... could be that there is a special configuration needed for the mdio communication (and id 0 was reported) or the switch actually use a not supported id |
|
Is the Netgear R7800 working correctly on 5.10? I guess yes, but I remember looking at this in the beginning and now lost track. |
|
thanks for your hard work ansuel... especially the nice linear spacing of all the recent major changes... spot on really appreciate having the 5.4 patches left in tree for a month-ish or so and the ability to build from those. |
The Netgear r7800 has been confirmed to work in v5.10, I guess the table at #4036 (comment) is still largely current (in the mean time I've successfully tested the ASRock G10 as well, albeit only within the DSA branch). Edit: Looking at the DSA PR, The Linksys EA7500 v1 seems to have also been tested successfully (using the DSA branch), which would add that to the tested devices and the EA8500 to the "(probably similar enough to expect it working)" ones. |
|
Commit message should be edited since this does not "drop" kernel 5.4. This will only be the case when config and patches are removed. It's still perfectly possible to build 5.4 if you just change this single variable. However, regarding DSA I understand it that way that 5.4 won't work anymore after DSA patches are introduced. Thus, we should actually remove kernel 5.4 support - by dropping patches/config - before that point. Due to the latter, I think we should move to default 5.10 soon; this will help to spot problems by a wider audience before we might introduce additional problems with DSA (so DSA will probably have to wait a few weeks after default 5.10 due to that reason). So, are there any known problem with 5.10 left at the moment? |
|
I've been using 5.10 on my R7800 and C2600 for a few months and had no problems whatsoever. |
|
@adschm aside the problem of instability with some very high load (present also on 5.4), no issue observed. Will change the message and remove the drop part |
Move kernel version to 5.10 as has been tested by many user with positive feedback. Patches for kernel 5.4 are kept for reference if for whatever reason someone still needs them or require to build an image with the old kernel version. Patch for 5.4 will later be dropped when this target will be migrated to DSA since too much effort are required to backport qca8k patch for 5.4 and won't work anymore. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Ansuel
changed the title
|
I compiled the current 5.10 version for R7800 and it works nicely ;-) |
Stupid question but here goes: is there anything special needed to switch from 5.4.x to 5.10.x on the R7800? Is it as simple as applying this PR, building, and flashing? |
|
no you actually test 5.10 by enabling the testing kernel version flag... |
OK. Just wanted to be sure nothing else was needed. I am happy to apply this PR and test on my R7800. I found this under a symbol search: But I do not see a corresponding option under Global build settings in my nconfig. What am I missing? |
|
if you have applied this pr then 5.10 is now the default version and testing kernel version flag is not available anymore. |
|
Got it. Apply, build, flash. Thank you. EDIT: Booted with no dmesg regressions and all functionality seems fine. |
I'm not aware of any regressions relative to v4.19 or v5.4 (yes, digitalcircuit is hunting a crash under load, but that one also happens with v5.4 and happened with v4.19 already, so this is not a regression in this PR). Stealing (and slightly updating) the table below from the DSA PR#4036, which implies using kernel v5.10: Tested, or very similar to a tested device:
Untested:
Unlikely to get feedback (expensive devboards, used by early adopters who have probably moved on meanwhile):
This test matrix successfully covers ipq8064 and ipq8065, just as well as spi-nor, NAND and eMMC storage. |
|
Thanks, I will merge this during the weekend. |
|
I'm sorry, won't build for me: on Debian 10 and 11 with default settings |
|
strange they are toolchain error not related to target compilation problem o.O my build env is ubuntu devel with gcc 11 |
|
@Ansuel Yes, of course not related, but I'm not able to build and thus test. In contrast, ipq40xx builds without problems. I.e. I'm not saying it's your fault. Maybe I will find time to test with 5.4 and narrow down the source of the problem. |
|
could be that some advanced toolchain flags are set that are not compatible with ipq806x ? |
|
Well, gcc 10 never really went smoothly on my systems. I'm still trying to get it build reliably here. |
|
This builds fine with gcc 8, so I decided to merge it anyway. |
|
Probably also the armvirt (32) target that provides the packages SDK for buildbot, should be toggled to 5.10 sooner or later. It has been "testing 5.10" since #4005 in April, but I am not sure what that actually indicates as buildbot is not really building the testing kernelSDK, and I think pretty much nobody builds armvirt separately for private builds. |
|
Merged commit is: |
Move kernel version to 5.10 as has been tested by many user
with positive feedback.
Patches for kernel 5.4 are kept for reference if for whatever
reason someone still needs them or require to build an image
with the old kernel version.
Patch for 5.4 will later be dropped when this target will
be migrated to DSA since too much effort are required to
backport qca8k patch for 5.4 and won't work anymore.
@hnyman @adschm Think it's time to move this target... If I have time i will also rework the dsa patch and move it to generic and hope to finally start to test that for other target. Did anyone notice the mail send to the mailing list?
Signed-off-by: Ansuel Smith ansuelsmth@gmail.com