noddos: fails to build #8349

nwf · 2019-03-06T00:48:30Z

Maintainer: @StevenHessing
Environment: OpenWrt HEAD

Description:

noddos fails to build with modern ipset library, after at least http://git.netfilter.org/ipset/commit/?id=55fdd96e331e920ee62bd816a572ac24f6dcd1ae. The compiler spew is as follows:

make[5]: Entering directory '/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5'
[  1%] Building CXX object src/CMakeFiles/Identifier_test.dir/DeviceProfile.cxx.o
In file included from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.h:44:0,
                 from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.cxx:23:
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h: In member function 'bool Ipset::Exists()':
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:102:70: error: invalid conversion from'int (*)(const char*, ...)' to 'ipset_print_outfn {aka int (*)(ipset_session*, void*, const char*, ...)}' [-fpermissive]
             struct ipset_session *session = ipset_session_init(printf);
                                                                      ^
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:102:70: error: too few arguments to function 'ipset_session* ipset_session_init(ipset_print_outfn, void*)'
In file included from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:37:0,
                 from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.h:44,
                 from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.cxx:23:
/tank/openwrt/scratch/builder-usbnetgw2/staging_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/usr/include/libipset/session.h:132:30: note: declared here
 extern struct ipset_session *ipset_session_init(ipset_print_outfn outfn,
                              ^~~~~~~~~~~~~~~~~~
In file included from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.h:44:0,
                 from /tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/DeviceProfile.cxx:23:
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:109:17: error: 'ipset_envopt_parse' was not declared in this scope
             if (ipset_envopt_parse(session, IPSET_ENV_EXIST, NULL) < 0) {
                 ^~~~~~~~~~~~~~~~~~
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:109:17: note: suggested alternative: 'ipset_envopt_unset'
             if (ipset_envopt_parse(session, IPSET_ENV_EXIST, NULL) < 0) {
                 ^~~~~~~~~~~~~~~~~~
                 ipset_envopt_unset
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:116:95: error: 'ipset_session_error' was not declared in this scope
                 syslog (LOG_ERR, "Ipset: Can't commit for setname %s: %s", ipsetName.c_str(), ipset_session_error(session));
                                                                                               ^~~~~~~~~~~~~~~~~~~
/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5/src/Ipset.h:116:95: note: suggested alternative: 'ipset_session_report'
                 syslog (LOG_ERR, "Ipset: Can't commit for setname %s: %s", ipsetName.c_str(), ipset_session_error(session));
                                                                                               ^~~~~~~~~~~~~~~~~~~
                                                                                               ipset_session_report
src/CMakeFiles/Identifier_test.dir/build.make:75: recipe for target 'src/CMakeFiles/Identifier_test.dir/DeviceProfile.cxx.o' failed
make[5]: *** [src/CMakeFiles/Identifier_test.dir/DeviceProfile.cxx.o] Error 1
make[5]: Leaving directory '/tank/openwrt/scratch/builder-usbnetgw2/build_dir/target-arm_cortex-a15+neon-vfpv4_musl_eabi/noddos-0.5.5'

The text was updated successfully, but these errors were encountered:

blueveryday · 2019-03-11T08:40:44Z

yes, I have the same to you.
Have no diea with it.

cotequeiroz · 2019-03-12T19:48:55Z

I have a tentative patch for this, but haven't run-tested it.
cotequeiroz@688462e
Despite the commit message, I'm not sure if I actually sumitted it to @StevenHessing.
If anyone can test this, I'll open a PR here and upstream (I do have the patch for upstream master).

blueveryday · 2019-03-13T00:50:54Z

I have a tentative patch for this, but haven't run-tested it.
cotequeiroz@688462e
Despite the commit message, I'm not sure if I actually sumitted it to @StevenHessing.
If anyone can test this, I'll open a PR here and upstream (I do have the patch for upstream master).

thank you sir.
it sucessed !
I had test your patches and makefile files,well done.

cotequeiroz · 2019-03-13T18:28:41Z

Can you describe what tests have you run, so that I can properly document the PR?

cotequeiroz · 2019-03-14T00:12:16Z

I meant if you actually ran the app in your router.

blueveryday · 2019-03-15T08:56:27Z

I meant if you actually ran the app in your router.

I got some errors.....

root@OpenWrt:/tmp# opkg install noddos*.ipk
Installing noddos (0.5.5-2) to root...
Multiple packages (libpthread and libpthread) providing same name marked HOLD or PREFER. Using latest.
Collected errors:

satisfy_dependencies_for: Cannot satisfy the following dependencies for noddos:
kernel (= 4.14.105-1-c2ffef75bd3568dbfe7d18082c40258a) *
opkg_install_cmd: Cannot install package noddos.
root@OpenWrt:/tmp#

and then , I compile the bin for my WR841v7 , including noddos and luci-app-noddos packages.
no errors up .
after flashed this bin , couldn't open 192.168.1.1 webpage.
I have no idea with it.......

cotequeiroz · 2019-03-15T12:08:42Z

Can you get ssh access?
If so, what webserver are you using? Check that it is running. When using nginx, I sometimes end up with no /etc/nginx/luci_nginx.conf. I haven't studied what happens. I just remove /overlay/upper/etc/nginx/luci_nginx*.conf (this will restore luci_nginx.conf and luci_nginx_ssl.conf files). In my case, they are marked as removed, so they do not show up in /etc/nginx/. Make sure you backup that directory first, just to be sure. Then reboot.

blueveryday · 2019-03-15T13:30:28Z

Can you get ssh access?
If so, what webserver are you using? Check that it is running. When using nginx, I sometimes end up with no /etc/nginx/luci_nginx.conf. I haven't studied what happens. I just remove /overlay/upper/etc/nginx/luci_nginx*.conf (this will restore luci_nginx.conf and luci_nginx_ssl.conf files). In my case, they are marked as removed, so they do not show up in /etc/nginx/. Make sure you backup that directory first, just to be sure. Then reboot.

I remove the noddos and luci-app-noddos when compiling image.
flash it , It's run very well.

cotequeiroz · 2019-03-15T15:01:56Z

So this does not fix it. Thank you for testing it.

blueveryday · 2019-03-15T23:07:21Z

So this does not fix it. Thank you for testing it.

You are welcome.
If you have new idea for it, I will be glad to test it.
Thank you so much.

cotequeiroz · 2019-03-18T13:09:39Z

I've tried to run it, no avail. It appears that its website site (https://www.noddos.io/) is down. When the app starts up, it gets the device profiles from that website, and hangs trying to download it. @StevenHessing, what's the status of this?

byoda · 2019-03-19T01:09:44Z

I'll get the website that hosted the device profiles back up in one or two days. Will need to look in to the ipset API changed

…

On Mon, Mar 18, 2019, 6:09 AM Eneas Queiroz ***@***.***> wrote: I've tried to run it, no avail. It appears that its website site ( https://www.noddos.io/) is down. When the app starts up, it gets the device profiles from that website, and hangs trying to download it. @StevenHessing <https://github.com/StevenHessing>, what's the status of this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8349 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWiy-bbJWqUMJmdJ9inuSc4PMQaQkUlUks5vX5AbgaJpZM4bfz46> .

byoda · 2019-03-19T16:38:23Z

The web-site is back up: root@WRT1200AC:~# /usr/bin/getnoddosdeviceprofiles; if [ $? -gt 0 ]; then service noddos reload; fi Verified OK On Mon, Mar 18, 2019 at 6:09 PM Steven Hessing <steven.hessing@gmail.com> wrote:

…

I'll get the website that hosted the device profiles back up in one or two days. Will need to look in to the ipset API changed On Mon, Mar 18, 2019, 6:09 AM Eneas Queiroz ***@***.***> wrote: > I've tried to run it, no avail. It appears that its website site ( > https://www.noddos.io/) is down. When the app starts up, it gets the > device profiles from that website, and hangs trying to download it. > @StevenHessing <https://github.com/StevenHessing>, what's the status of > this? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#8349 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AWiy-bbJWqUMJmdJ9inuSc4PMQaQkUlUks5vX5AbgaJpZM4bfz46> > . >

cotequeiroz · 2019-03-19T21:17:21Z

I've managed to test it some, and have posted noddos/noddos#53 with the ipset 7 changes to master. I will probably open a new one adjusting getnoddosdeviceprofiles to account for wget being provided by uclient-fetch, which does not support the --timestamping option.

cotequeiroz · 2019-03-20T12:36:23Z

your mean is that noddos well done ?

It should work if you install wget, and the patch you've tried before. The reason why it was locking up before was because https://noddos.io/ was down. Now that's up again, it should work. The reason I asked you to install wget as well is that noddos uses a flag that's not available with uclient-fetch's implementation of wget.

blueveryday · 2019-03-21T00:25:44Z

your mean is that noddos well done ?

It should work if you install wget, and the patch you've tried before. The reason why it was locking up before was because https://noddos.io/ was down. Now that's up again, it should work. The reason I asked you to install wget as well is that noddos uses a flag that's not available with uclient-fetch's implementation of wget.

thank you very much .
I will test it.

cotequeiroz mentioned this issue Apr 2, 2019

Buildbot failures #8548

Closed

cotequeiroz mentioned this issue Apr 22, 2019

noddos: add libipset-7, uclient-fetch compatiblity #8758

Merged

neheb closed this as completed in #8758 Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

noddos: fails to build #8349

noddos: fails to build #8349

nwf commented Mar 6, 2019

blueveryday commented Mar 11, 2019

cotequeiroz commented Mar 12, 2019 •

edited

blueveryday commented Mar 13, 2019

cotequeiroz commented Mar 13, 2019

cotequeiroz commented Mar 14, 2019

blueveryday commented Mar 15, 2019 •

edited

cotequeiroz commented Mar 15, 2019

blueveryday commented Mar 15, 2019

cotequeiroz commented Mar 15, 2019

blueveryday commented Mar 15, 2019

cotequeiroz commented Mar 18, 2019

byoda commented Mar 19, 2019 via email

byoda commented Mar 19, 2019 via email

cotequeiroz commented Mar 19, 2019

cotequeiroz commented Mar 20, 2019

blueveryday commented Mar 21, 2019

noddos: fails to build #8349

noddos: fails to build #8349

Comments

nwf commented Mar 6, 2019

blueveryday commented Mar 11, 2019

cotequeiroz commented Mar 12, 2019 • edited

blueveryday commented Mar 13, 2019

cotequeiroz commented Mar 13, 2019

cotequeiroz commented Mar 14, 2019

blueveryday commented Mar 15, 2019 • edited

cotequeiroz commented Mar 15, 2019

blueveryday commented Mar 15, 2019

cotequeiroz commented Mar 15, 2019

blueveryday commented Mar 15, 2019

cotequeiroz commented Mar 18, 2019

byoda commented Mar 19, 2019 via email

byoda commented Mar 19, 2019 via email

cotequeiroz commented Mar 19, 2019

cotequeiroz commented Mar 20, 2019

blueveryday commented Mar 21, 2019

cotequeiroz commented Mar 12, 2019 •

edited

blueveryday commented Mar 15, 2019 •

edited