Skip to content

django-cors-headers: add python3 package#10374

Merged
neheb merged 1 commit into
openwrt:masterfrom
peter-stadler:django-cors-headers
Nov 5, 2019
Merged

django-cors-headers: add python3 package#10374
neheb merged 1 commit into
openwrt:masterfrom
peter-stadler:django-cors-headers

Conversation

@peter-stadler
Copy link
Copy Markdown
Contributor

@peter-stadler peter-stadler commented Oct 28, 2019

Maintainer: Peter Stadler peter.stadler@student.uibk.ac.at
Compile tested: MIPS 74K, Asus RT-N16, master snapshot
Run tested: MIPS 74K, Asus RT-N16, master snapshot, used by etesync-server

Description: This is a dependency for the etesync-server (I will update the linked PR later) and needs the sqlparse PR.

@neheb
Copy link
Copy Markdown
Contributor

neheb commented Oct 29, 2019

Comment thread lang/python/python3-sqlparse/Makefile Outdated
@peter-stadler
Copy link
Copy Markdown
Contributor Author

peter-stadler commented Oct 29, 2019

Thanks :-) I removed the sqlparse commit and use pypi.mk now. Furthermore, I added a -src package.

@peter-stadler
Copy link
Copy Markdown
Contributor Author

(nothing changed)

Comment thread lang/python/python3-django-cors-headers/Makefile Outdated
This is a dependency for the etesync-server and is using django and urllib.

Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
@peter-stadler
Copy link
Copy Markdown
Contributor Author

Thank you, I changed that.

It was my misunderstanding that the depends are run time dependencies as sqlparse is not in django. So the dependency should go into that package, right?
Without sqlparse the etesync-server was not running, but in the source files there is no import of sqlparse, as far as I see it is only in:

ipkg-install/usr/lib/python3.8/site-packages/django/db/backends/base/operations.py:import sqlparse
ipkg-install/usr/lib/python3.8/site-packages/django/db/backends/sqlite3/introspection.py:import sqlparse

@jefferyto
Copy link
Copy Markdown
Member

Yes, it appears Django 2 added sqlparse as a dependency. I suggest opening a PR to add it to the django package after the sqlparse package is merged.

@neheb neheb merged commit f095101 into openwrt:master Nov 5, 2019
@peter-stadler peter-stadler deleted the django-cors-headers branch November 5, 2019 13:42
@peter-stadler peter-stadler restored the django-cors-headers branch November 5, 2019 14:12
@peter-stadler peter-stadler deleted the django-cors-headers branch November 5, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants