django-cors-headers: add python3 package#10374
Merged
Merged
Conversation
This was referenced Oct 28, 2019
Contributor
|
Could use https://github.com/openwrt/packages/blob/master/lang/python/pypi.mk instead. ping @jefferyto |
BKPepe
reviewed
Oct 29, 2019
4f69a30 to
805df1f
Compare
Contributor
Author
|
Thanks :-) I removed the sqlparse commit and use pypi.mk now. Furthermore, I added a -src package. |
commodo
approved these changes
Oct 30, 2019
805df1f to
e235d98
Compare
Contributor
Author
|
(nothing changed) |
jefferyto
reviewed
Oct 31, 2019
This is a dependency for the etesync-server and is using django and urllib. Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
e235d98 to
9298aa6
Compare
Contributor
Author
|
Thank you, I changed that. It was my misunderstanding that the depends are run time dependencies as sqlparse is not in django. So the dependency should go into that package, right? |
Member
|
Yes, it appears Django 2 added sqlparse as a dependency. I suggest opening a PR to add it to the |
jefferyto
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: Peter Stadler peter.stadler@student.uibk.ac.at
Compile tested: MIPS 74K, Asus RT-N16, master snapshot
Run tested: MIPS 74K, Asus RT-N16, master snapshot, used by etesync-server
Description: This is a dependency for the etesync-server (I will update the linked PR later) and needs the sqlparse PR.