Skip to content

drf-nested-routers: add python3 package#10376

Merged
neheb merged 1 commit into
openwrt:masterfrom
peter-stadler:drf-nested-routers
Nov 5, 2019
Merged

drf-nested-routers: add python3 package#10376
neheb merged 1 commit into
openwrt:masterfrom
peter-stadler:drf-nested-routers

Conversation

@peter-stadler
Copy link
Copy Markdown
Contributor

Maintainer: Peter Stadler peter.stadler@student.uibk.ac.at
Compile tested: MIPS 74K, Asus RT-N16, master snapshot
Run tested: MIPS 74K, Asus RT-N16, master snapshot, used by etesync-server

Description: This is a dependency of the etesync-server (I will update the corresponding PR later) and uses the rest framework of django.

@neheb
Copy link
Copy Markdown
Contributor

neheb commented Oct 29, 2019

Copy link
Copy Markdown
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, look at this PR #10242 and would be good if it can be added as the example, which is there.

PKG_LICENSE_FILES can be added.

Comment thread lang/python/python3-drf-nested-routers/Makefile Outdated
Comment thread lang/python/python3-drf-nested-routers/Makefile Outdated
Comment thread lang/python/python3-drf-nested-routers/Makefile Outdated
Comment thread lang/python/python3-drf-nested-routers/Makefile Outdated
Comment thread lang/python/python3-drf-nested-routers/Makefile
@peter-stadler
Copy link
Copy Markdown
Contributor Author

Thank you again :-) I changed it to use pypi.mk fixing the license info and adding a source package, too.

@commodo
Copy link
Copy Markdown
Contributor

commodo commented Oct 30, 2019

from my side this is fine;
others have pointed out issues, so aside from those, there is nothing to add [from me]

@peter-stadler
Copy link
Copy Markdown
Contributor Author

peter-stadler commented Oct 30, 2019

Thank you. I did add the dependency on python3-django explicitly. I would investigate which packages from full python3 are needed, when python3-django depends on python3-light instead of python3.

@peter-stadler
Copy link
Copy Markdown
Contributor Author

(nothing changed)

@jefferyto
Copy link
Copy Markdown
Member

Aside from adding python3-light (if that is indeed correct), if would be great if you can squash the commits as well.

This is a dependency of the etesync-server and uses the rest framework of django.

Edit: Remove runtests and add dependencies on python3-django and python3-light.

Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
@peter-stadler
Copy link
Copy Markdown
Contributor Author

I did squash the commits and added python3-light, the imports work well with it.
Furthermore, I removed the runtests directory.

Copy link
Copy Markdown
Member

@jefferyto jefferyto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@neheb neheb merged commit f246780 into openwrt:master Nov 5, 2019
@peter-stadler peter-stadler deleted the drf-nested-routers branch November 5, 2019 13:42
@peter-stadler peter-stadler restored the drf-nested-routers branch November 5, 2019 14:12
@peter-stadler peter-stadler deleted the drf-nested-routers branch November 5, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants