New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib2: fix mips16 build, add size reducing static link, fpic CFLAGS #10780
Conversation
93903dc
to
0116a38
Compare
|
There is a newer version available (2.63.2) and it contains security fixes |
Sorry i'm not the maintainer, i just try to get my cifsd package ready for prime-time, to replace the ancient samba36 or at least offer a tiny alternative to samba4. I already suspect that this PR might sit here for a while, so i'm not adding any more changes, sorry. |
|
@dengqf6 is 2.58 EOL? |
0116a38
to
0377890
Compare
|
@neheb Why was this submitted and committed, this does not actually solve the issue and fails the same way as before? What's going on here? verify i used the new patch: |
|
Bah it seems I sent something without properly testing. I tested running the toolchain GCC and trying out multiple command line options to see the effects. no options: __mips = 1 I will retest. I suspect the mcpu or mtune settings are turning __mips to 32, even with -mips16 |
|
Yep that's exactly it. Will send another patch upstream. |
|
ping @tripolar This is blocking the cifsd update. |
|
This must be rebased. |
0377890
to
f1d726a
Compare
* allows building as mips16 (fixes broken mips16/32 mixed static linking) * add some static link related flags to reduce target binary size Signed-off-by: Andy Walsh <andy.walsh44+github@gmail.com>
f1d726a
to
a558b20
Compare
|
ping @tripolar this is ready. |
|
Merging as this is needed for smbd. |
Maintainer: @tripolar
Compile tested: mips/arm (master)
Run tested: mips/lantiq, arm/mvebu (master)
Description:
PS: I did test static glib2 via cifsd static build and shared via Midnight Commander package on both platforms and had no issues.