Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchcat: add restart_iface and ping size features + refactor #14225

Merged
merged 3 commits into from Dec 23, 2020

Conversation

mips171
Copy link
Contributor

@mips171 mips171 commented Dec 14, 2020

Maintainer: @roger-
Compile tested: ath79/Telco T1
Run tested: ath79/Telco T1, git master
Description:
Adds features and refactors code with aim to be more maintainable. The package version bumps multiple times because this is split across multiple commits.

Features

  • ability to restart a specific interface
  • ability to specify ping packet size
  • backwards compatibility with older mode names

LuCI
luci-app-watchcat has been updated to support these features: openwrt/luci#4658

Nicholas Smith and others added 2 commits December 14, 2020 13:16
Signed-off-by: Nicholas Smith <nicholas@nbembedded.com>
Signed-off-by: Nicholas Smith <nicholas@nbembedded.com>
@mips171 mips171 changed the title Update watchcat util watchcat: add restart_iface and ping size features + refactor Dec 14, 2020
@mips171
Copy link
Contributor Author

mips171 commented Dec 15, 2020

Does anyone know why the build is failing on arc_arc700? @neheb ?

@neheb
Copy link
Contributor

neheb commented Dec 17, 2020

Don't worry too much about it. It should go away soon.

Signed-off-by: Nicholas Smith <nicholas@nbembedded.com>
@mips171
Copy link
Contributor Author

mips171 commented Dec 23, 2020

Are we ready to merge this? I think the main benefit is that it's now easy to extend watchcat to support more actions.

@neheb neheb merged commit d504730 into openwrt:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants