Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsproxy: Update to 0.39.0 and add init script #16198

Merged
merged 2 commits into from Jul 24, 2021

Conversation

1715173329
Copy link
Member

@1715173329 1715173329 commented Jul 22, 2021

Maintainer: me
Compile tested: ipq807x, rockchip
Run tested: rk3328 nanopi-r2s

Description:

  • Updated to latest 0.39.0 release
  • Added basic init script

@1715173329
Copy link
Member Author

Related discussion: AdguardTeam/dnsproxy#111

Cc: @dhewg

Copy link
Contributor

@dhewg dhewg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this!
Left some comments ;)

net/dnsproxy/files/dnsproxy.config Show resolved Hide resolved
net/dnsproxy/files/dnsproxy.config Show resolved Hide resolved
net/dnsproxy/files/dnsproxy.init Show resolved Hide resolved
net/dnsproxy/files/dnsproxy.init Outdated Show resolved Hide resolved
net/dnsproxy/files/dnsproxy.init Show resolved Hide resolved
net/dnsproxy/files/dnsproxy.init Show resolved Hide resolved
@dhewg
Copy link
Contributor

dhewg commented Jul 23, 2021

Looks pretty good to me now, but you're not creating the user/group it's now using.
The Makefile misses a USERID:=dnsproxy=411:dnsproxy=411 or similar

@1715173329
Copy link
Member Author

Looks pretty good to me now, but you're not creating the user/group it's now using.
The Makefile misses a USERID:=dnsproxy=411:dnsproxy=411 or similar

Thank you so much! It's new to me.

@dhewg
Copy link
Contributor

dhewg commented Jul 23, 2021

LGTM and it even works fine for me, thanks!

@1715173329 1715173329 changed the title dnsproxy: Update to 0.38.3 and add init script dnsproxy: Update to 0.39.0 and add init script Jul 23, 2021
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
@neheb neheb merged commit 83304d7 into openwrt:master Jul 24, 2021
@1715173329 1715173329 deleted the dnsproxy branch July 24, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants