Skip to content

shadowsocks-libev: drop the package #24540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

yousong
Copy link
Member

@yousong yousong commented Jul 9, 2024

Maintainer: me
Compile tested: N/A
Run tested: N/A

Description:

The upstream project is declared as bugfix-only and received no update for about 2 years. The developement focus there has shifted. It does not compile with current openwrt main branch.

The upstream project is declared as bugfix-only and received no update
for about 2 years.  The developement focus there has shifted.  It does
not compile with current openwrt main branch.

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
@yousong yousong force-pushed the remove-ss-libev branch from cee2106 to 6c03cc6 Compare July 9, 2024 05:46
@msdos03
Copy link
Contributor

msdos03 commented Jul 9, 2024

I think we shouldn't remove it, because this is the most lightweight implement of shadowsocks. Rust version of it takes up to 4 times more RAM. For many routers, this is important. And we have solution to the compilation problem now.

@yousong
Copy link
Member Author

yousong commented Jul 9, 2024

I think we shouldn't remove it, because this is the most lightweight implement of shadowsocks. Rust version of it takes up to 4 times more RAM. For many routers, this is important. And we have solution to the compilation problem now.

OpenWrt as a downstream project is not to act as a fork of shadowsocks-libev. Like said in the description, the dev efforts of shadowsocks community has shifted. Shadowsocks-libev is now a stale project.

@msdos03
Copy link
Contributor

msdos03 commented Jul 9, 2024

@yousong I think before shadowsocks-rust is added to packages, shadowsocks-libev should be reserved. It's common to add dependency fix patch to those projects that are not willing to do that. This package is still widely used.
The community is still paying effort on this package, so at least keep it until nobody want to fix it.

@zxlhhyccc
Copy link

zxlhhyccc commented Jul 9, 2024

@yousong I agree @msdos03 viewpoint. whether a project is abandoned should consider whether it is actually used by users. For now, this software is still being used by a large number of people, including the server side. So I wouldn't recommend abandoning the project. Unless it's no longer maintained or obsolete. And now that the patch suitable for the main branch has been submitted, it should not be abandoned.

Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be merged I agree with @yousong . This is for the master branch. We talked about it one year ago in #22356 (comment) . Users should switch to shadowsocks-rust if possible.

@msdos03
Copy link
Contributor

msdos03 commented Jul 9, 2024

This one should be merged I agree with @yousong . This is for the master branch. We talked about it one year ago in #22356 (comment) . Users should switch to shadowsocks-rust if possible.

Until now, shadowsocks-rust still haven't been added.

@BKPepe
Copy link
Member

BKPepe commented Jul 9, 2024

There was PR #22477

@zxlhhyccc
Copy link

zxlhhyccc commented Jul 9, 2024

@BKPepe shadowsocks-rust After compiling, it takes up a large space, and the routing of small flash memory is basically unusable. So I think shadowsocks-libev should be retained in order to take care of routing of small flash memory.

@msdos03
Copy link
Contributor

msdos03 commented Jul 9, 2024

There was PR #22477

But it still haven't been merged. And indeed, shadowsocks-rust have very large binary size (more than 5MB) and RAM consumption (more than 10MB) compared to libev. For routers, these are important.

@zxlhhyccc
Copy link

zxlhhyccc commented Jul 9, 2024

@BKPepe @yousong Retention strongly recommended shadowsocks-libev. moreover,the currently active branch shadowsocks-rust has deprecated tcp fast open.

@1715173329
Copy link
Member

The upstream has abandoned libev port and does not accept PRs anymore, there are no active forks too, so it's just dead.

The community is still paying effort on this package, so at least keep it until nobody want to fix it.

As metioned above, we have discussed removing this package several times, but basically nobody cares.
Maintaining a deprecated (now broken) stuff is really painful, and yousong seems to be too busy to have much effort to maintain it.
In this case, removing it is definitely a better choice rather than wait a (maybe nonexistent) random person to fix it.

Rust version of it takes up to 4 times more RAM. For many routers, this is important.

I don't think it's that "important". It's 2024, any modern routers should have at least 256 MB RAM, it's pretty enouth for ss-rust and other daemons. Not to mention there are even a certain number of people running clash on mt7621.
For those old devices with limited performance, using old branches is a better option.

@BKPepe BKPepe merged commit 49b8380 into openwrt:master Jul 10, 2024
12 checks passed
yousong added a commit to yousong/luci that referenced this pull request Jul 10, 2024
Related pull request: openwrt/packages#24540

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
yousong added a commit to openwrt/luci that referenced this pull request Jul 10, 2024
Related pull request: openwrt/packages#24540

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
systemcrash pushed a commit to weblate/luci that referenced this pull request Jul 10, 2024
Related pull request: openwrt/packages#24540

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
@WeihanLi
Copy link

Should the document be updated to reflect this change, currently, the links in the docs page would lead to 404 due to this remove
docs page link: https://openwrt.org/docs/guide-user/services/proxy/shadowsocks

@yousong
Copy link
Member Author

yousong commented Jul 18, 2024

Should the document be updated to reflect this change, currently, the links in the docs page would lead to 404 due to this remove docs page link: https://openwrt.org/docs/guide-user/services/proxy/shadowsocks

I just added a note describing the drop done here and updated links there to point to the openwrt-23.05 branch.

@zdj0925
Copy link

zdj0925 commented Jul 19, 2024

现在有什么推荐的替代品吗?体积小、快速、占用内存小。

@WeihanLi
Copy link

WeihanLi commented Jul 19, 2024

现在有什么推荐的替代品吗?体积小、快速、占用内存小。

同问 v2ray 安装包有点大,路由器装不了 😂

@yousong
Copy link
Member Author

yousong commented Jul 19, 2024

I am going to lock the session here. Please open a new issue or forum post for further discussions.

Show your respects guys. This is a open place where English is the preferred lang. Not that we are all native or master speakers of that lang, but that other people can join.

@openwrt openwrt locked as off-topic and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants